Feature/fga/pinned messages fix timeline provider

[ganfra]

Content

Fix cases where navigation causes PinnedMessagesTimelineProvider to close the timeline.

Motivation and context

Closes https://github.com/element-hq/element-internal/issues/623

Screenshots / GIFs

Tests

• Open a room with pinned messages
• Go to the room settings, then click pinned messages
• Play with navigation (use View in timeline and unpin actions)
• Check banner and list are always up-to-date with the pinned messages state event.

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/X34vzb

[codecov]

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.61%. Comparing base (67e262f) to head (99158da).

Files with missing lines	Patch %	Lines
...ssages/impl/pinned/PinnedEventsTimelineProvider.kt	53.33%	5 Missing and 2 partials ⚠️
...es/impl/pinned/list/PinnedMessagesListPresenter.kt	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3432      +/-   ##
===========================================
- Coverage    82.62%   82.61%   -0.02%     
===========================================
  Files         1699     1699              
  Lines        39979    39989      +10     
  Branches      4864     4866       +2     
===========================================
+ Hits         33033    33036       +3     
- Misses        5229     5233       +4     
- Partials      1717     1720       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[jmartinesp]

I can confirm it's fixed, thanks!