Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pinned message actions #3438

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Sep 10, 2024

Content

This PR handles 2 things :

  • Removes the redact action from the pinned message list context menu.
  • Allow to unpin redacted events so you are not stuck with useless pinned events.

Motivation and context

https://github.com/element-hq/element-internal/issues/621

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@ganfra ganfra added the PR-Change For updates to an existing feature label Sep 10, 2024
@ganfra ganfra marked this pull request as ready for review September 10, 2024 11:54
@ganfra ganfra requested a review from a team as a code owner September 10, 2024 11:54
@ganfra ganfra requested review from bmarty and removed request for a team September 10, 2024 11:54
Copy link
Contributor

github-actions bot commented Sep 10, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/5LdYN6

@ganfra ganfra changed the title [Changes] Pinned message actions Update pinned message actions Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.63%. Comparing base (7238af7) to head (f6c6943).
Report is 16 commits behind head on develop.

Files with missing lines Patch % Lines
...es/messages/impl/actionlist/ActionListPresenter.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3438      +/-   ##
===========================================
- Coverage    82.63%   82.63%   -0.01%     
===========================================
  Files         1702     1702              
  Lines        40055    40050       -5     
  Branches      4872     4870       -2     
===========================================
- Hits         33100    33095       -5     
+ Misses        5234     5233       -1     
- Partials      1721     1722       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 16, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 16, 2024
@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 16, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 16, 2024
Copy link

sonarcloud bot commented Sep 16, 2024

@ganfra ganfra merged commit d310c96 into develop Sep 16, 2024
29 of 30 checks passed
@ganfra ganfra deleted the feature/fga/pinned_messages_actions branch September 16, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Change For updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants