Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update application store assets #3441

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Sep 10, 2024

Content

Add a new image and update title, short description and long description of the application.

New content will be used once the PR is merged for the next release on F-Droid.
For GPlay, I'll update the content on the PlayStore once the PR has been approved and merged.

  • content updated on the PlayStore

Motivation and context

Screenshots / GIFs

Tests

  • NA

Tested devices

  • NA

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner September 10, 2024 21:21
@bmarty bmarty requested review from jmartinesp and mxandreas and removed request for a team September 10, 2024 21:21
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/22Ji76

Copy link

sonarcloud bot commented Sep 10, 2024

@bmarty bmarty added the PR-Misc For other changes label Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.61%. Comparing base (78d13fc) to head (56b0553).
Report is 12 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3441      +/-   ##
===========================================
- Coverage    82.61%   82.61%   -0.01%     
===========================================
  Files         1699     1699              
  Lines        39989    39989              
  Branches      4866     4866              
===========================================
- Hits         33036    33035       -1     
  Misses        5233     5233              
- Partials      1720     1721       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bmarty bmarty merged commit eb43c28 into develop Sep 11, 2024
30 checks passed
@bmarty bmarty deleted the feature/bma/iterateOnStoreAssets branch September 11, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants