Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/valere/invisible crypto feature flag #3451

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

BillCarsonFr
Copy link
Member

Fixes #3043

Content

Adds a new feature flag to enable invisible crypto. Default is false (can be enabled in dev tool)
image

When this mode is enabled, device not verified by their owners will not receive decryption keys:
image

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@BillCarsonFr BillCarsonFr requested a review from a team as a code owner September 12, 2024 09:55
@BillCarsonFr BillCarsonFr requested review from bmarty and removed request for a team September 12, 2024 09:55
Copy link
Contributor

github-actions bot commented Sep 12, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/GpLbRH

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you have to fix the issue in building the minimal app.

@ganfra ganfra force-pushed the feature/valere/invisible_crypto_feature_flag branch from 9ec96e4 to bb50d3e Compare September 12, 2024 12:54
@ganfra ganfra added the PR-Change For updates to an existing feature label Sep 12, 2024
Copy link

sonarcloud bot commented Sep 12, 2024

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.62%. Comparing base (b4afc32) to head (bb50d3e).
Report is 25 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3451   +/-   ##
========================================
  Coverage    82.61%   82.62%           
========================================
  Files         1700     1700           
  Lines        40003    40009    +6     
  Branches      4868     4868           
========================================
+ Hits         33049    33056    +7     
  Misses        5233     5233           
+ Partials      1721     1720    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 12, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 12, 2024
@ganfra ganfra merged commit da3f5e0 into develop Sep 12, 2024
33 checks passed
@ganfra ganfra deleted the feature/valere/invisible_crypto_feature_flag branch September 12, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Change For updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invisible Crypto: Add new developer option to enable invisible crypto key distribution mode
3 participants