-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/valere/invisible crypto feature flag #3451
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but you have to fix the issue in building the minimal app.
9ec96e4
to
bb50d3e
Compare
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3451 +/- ##
========================================
Coverage 82.61% 82.62%
========================================
Files 1700 1700
Lines 40003 40009 +6
Branches 4868 4868
========================================
+ Hits 33049 33056 +7
Misses 5233 5233
+ Partials 1721 1720 -1 ☔ View full report in Codecov by Sentry. |
Fixes #3043
Content
Adds a new feature flag to enable invisible crypto. Default is false (can be enabled in dev tool)
When this mode is enabled, device not verified by their owners will not receive decryption keys:
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist