-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix not being able to decline an invite from the room list #3466
Conversation
At the moment, this is a wrapper that allows us to call `Room.leave()` without having to initialise the room's timeline (which is impossible).
Also, `RustRoomFactory` now has a `createInvitedRoom` method for this.
Fix the tests.
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3466 +/- ##
========================================
Coverage 82.63% 82.63%
========================================
Files 1701 1702 +1
Lines 40047 40055 +8
Branches 4872 4872
========================================
+ Hits 33092 33100 +8
Misses 5234 5234
Partials 1721 1721 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Content
RoomListItem.invitedRoom()
API to get a room in an invited membership state that won't need a timeline to work.AcceptDeclineInvitePresenter
get an invited room instead of the full room and decline the invite.Motivation and context
Fixes #3407.
Note the implementation is a quick fix and some iteration on this issue is encouraged: ideally, we'd have
JoinedRoom
andInvitedRoom
abstractions that share a minimum of logic, and maybe both implement a simplifiedMatrixRoom
.Tests
Tested devices
Checklist