Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Rust sdk to 0.2.45 #3472

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Upgrade Rust sdk to 0.2.45 #3472

merged 4 commits into from
Sep 17, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Sep 17, 2024

Content

Upgrade SDK to 0.2.45 commit matrix-org/matrix-rust-sdk@abbe2ec

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner September 17, 2024 08:24
@bmarty bmarty requested review from ganfra and removed request for a team September 17, 2024 08:24
@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 17, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 17, 2024
@bmarty bmarty added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Sep 17, 2024
Copy link
Contributor

github-actions bot commented Sep 17, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Ymx1Nb

Copy link

sonarcloud bot commented Sep 17, 2024

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.58%. Comparing base (ff29461) to head (265c60a).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3472   +/-   ##
========================================
  Coverage    82.58%   82.58%           
========================================
  Files         1723     1723           
  Lines        40566    40566           
  Branches      4942     4942           
========================================
  Hits         33501    33501           
  Misses        5317     5317           
  Partials      1748     1748           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 17, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 17, 2024
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM, thanks!

@bmarty bmarty merged commit ce03ca5 into develop Sep 17, 2024
29 of 30 checks passed
@bmarty bmarty deleted the feature/bma/sdkUpgrade2 branch September 17, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants