Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish between roomId and roomAlias. #3486

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Sep 18, 2024

Content

Ensure that MatrixPatternType is correctly set.

Motivation and context

Fix crash (in debug mode) where RoomAlias was use to host a roomId.

Screenshots / GIFs

Tests

  • In debug mode
  • Open a room with permalink on Event
  • observe that the app is not crashing anymore.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty added the PR-Bugfix For bug fix label Sep 18, 2024
@bmarty bmarty requested a review from a team as a code owner September 18, 2024 10:29
@bmarty bmarty requested review from ganfra and removed request for a team September 18, 2024 10:29
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/jgzGpA

Copy link

sonarcloud bot commented Sep 18, 2024

@bmarty bmarty merged commit e95388f into develop Sep 18, 2024
28 checks passed
@bmarty bmarty deleted the feature/bma/fixRoomAliasMatcch branch September 18, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants