Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeline related improvements #3487

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Timeline related improvements #3487

merged 2 commits into from
Sep 18, 2024

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Sep 18, 2024 •
edited
Loading

Content

Two changes in this PR, related to timeline :

  • Pinned timeline items doesn't need debounce anymore
  • Regular timeline was briefly emitting empty list when navigating back

Motivation and context

Closes #3454

Screenshots / GIFs

Tests

  • Open room
  • Scroll backward in the timeline
  • Open room details
  • Press back
  • See timeline kept his position

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@ganfra ganfra added the PR-Misc For other changes label Sep 18, 2024
@ganfra ganfra marked this pull request as ready for review September 18, 2024 12:04
@ganfra ganfra requested a review from a team as a code owner September 18, 2024 12:04
@ganfra ganfra requested review from jmartinesp and removed request for a team September 18, 2024 12:04
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 18, 2024 •
edited
Loading

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/rk1iBf

@codecov Codecov
Copy link

codecov bot commented Sep 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.67%. Comparing base (df72d28) to head (1242316).
Report is 11 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #3487   +/-   ##
========================================
  Coverage    82.67%   82.67%           
========================================
  Files         1731     1731           
  Lines        40834    40834           
  Branches      4967     4967           
========================================
  Hits         33760    33760           
  Misses        5312     5312           
  Partials      1762     1762

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty
Copy link
Member

bmarty commented Sep 18, 2024

Does this close #3454 ?

@ganfra
Copy link
Member Author

ganfra commented Sep 18, 2024 •
edited
Loading

Does this close #3454 ?

I guess!

jmartinesp
jmartinesp approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes work fine, thanks! I just left a comment, feel free to ignore it.

...impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/TimelinePresenter.kt Outdated
@@ -81,6 +82,7 @@ class TimelinePresenter @AssistedInject constructor(
computeReactions = true,
)
)
private val timelineItems = mutableStateOf<ImmutableList<TimelineItem>>(persistentListOf())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can probably use private var timelineItems by and it should work, and you won't need the var timelineItems by this.timelineItems line below.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you're right, I don't know why on my mind it was only possible inside Composable 😅

@ganfra ganfra force-pushed the feature/fga/timeline_improvements branch from b2ffba9 to 1242316 Compare September 18, 2024 14:27
@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 18, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 18, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 18, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 18, 2024
@ganfra ganfra merged commit 2d31308 into develop Sep 18, 2024
33 checks passed
@ganfra ganfra deleted the feature/fga/timeline_improvements branch September 18, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinesp jmartinesp jmartinesp approved these changes

Assignees
No one assigned
Labels
PR-Misc For other changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In certain cases, the timeline position cannot be remembered.
3 participants
@ganfra @bmarty @jmartinesp