Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and fixtures for SDK classes. #3488

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Sep 18, 2024

Content

Replacement for #3482 : revert change about interface, but keep the cleanup and move fixtures in a dedicated packages.

Motivation and context

Clean code.

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner September 18, 2024 12:35
@bmarty bmarty requested review from ganfra and removed request for a team September 18, 2024 12:35
@bmarty bmarty added the PR-Misc For other changes label Sep 18, 2024
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/fhbEu6

Copy link

sonarcloud bot commented Sep 18, 2024

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.67%. Comparing base (df72d28) to head (352dbdb).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3488   +/-   ##
========================================
  Coverage    82.67%   82.67%           
========================================
  Files         1731     1731           
  Lines        40834    40834           
  Branches      4967     4967           
========================================
  Hits         33760    33760           
  Misses        5312     5312           
  Partials      1762     1762           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 18, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 18, 2024
@bmarty bmarty merged commit 7922243 into develop Sep 18, 2024
34 checks passed
@bmarty bmarty deleted the feature/bma/cleanupAndFixtures branch September 18, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants