-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Room list : debounce subscribe to visible rooms. #3491
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but it seems that some test(s) are failing
I fixed those in 4b2ea11, added a separate test for cancellation 🤞 . |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3491 +/- ##
========================================
Coverage 82.67% 82.67%
========================================
Files 1731 1731
Lines 40841 40842 +1
Branches 4968 4968
========================================
+ Hits 33764 33766 +2
Misses 5315 5315
+ Partials 1762 1761 -1 ☔ View full report in Codecov by Sentry. |
Content
Avoid cancelling sync request too often because we subscribe to visible rooms by adding a debounce.
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist