Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room list : debounce subscribe to visible rooms. #3491

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Sep 18, 2024

Content

Avoid cancelling sync request too often because we subscribe to visible rooms by adding a debounce.

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@ganfra ganfra added the PR-Misc For other changes label Sep 18, 2024
@ganfra ganfra marked this pull request as ready for review September 18, 2024 19:10
@ganfra ganfra requested a review from a team as a code owner September 18, 2024 19:10
@ganfra ganfra requested review from jmartinesp and removed request for a team September 18, 2024 19:10
Copy link
Contributor

github-actions bot commented Sep 18, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/yUKA1A

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it seems that some test(s) are failing

@jmartinesp
Copy link
Member

LGTM, but it seems that some test(s) are failing

I fixed those in 4b2ea11, added a separate test for cancellation 🤞 .

Copy link

sonarcloud bot commented Sep 19, 2024

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.67%. Comparing base (2d31308) to head (4b2ea11).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3491   +/-   ##
========================================
  Coverage    82.67%   82.67%           
========================================
  Files         1731     1731           
  Lines        40841    40842    +1     
  Branches      4968     4968           
========================================
+ Hits         33764    33766    +2     
  Misses        5315     5315           
+ Partials      1762     1761    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 19, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 19, 2024
@ganfra ganfra merged commit 63bf1d0 into develop Sep 19, 2024
30 checks passed
@ganfra ganfra deleted the feature/fga/room_list_debounce_subscribe branch September 19, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants