Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include inviter in the notification for invitation #3503

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Sep 20, 2024

Content

Include the sender name (or id) in the notification for invitation.

Second commit is test cleanup.

Motivation and context

More useful notification

Screenshots / GIFs

Before After
Screenshot 2024-09-20 at 10 28 00 Screenshot 2024-09-20 at 11 27 01

Note: rendering on iOS:

image

Tests

  • Get invited to a room or to a DM and observe the content of the notification

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty added the PR-Change For updates to an existing feature label Sep 20, 2024
@bmarty bmarty requested a review from a team as a code owner September 20, 2024 10:43
@bmarty bmarty requested review from ganfra and removed request for a team September 20, 2024 10:43
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/gpfhAd

Copy link

sonarcloud bot commented Sep 20, 2024

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 20, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.67%. Comparing base (dfe9323) to head (6fc801e).
Report is 32 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3503   +/-   ##
========================================
  Coverage    82.67%   82.67%           
========================================
  Files         1731     1731           
  Lines        40844    40852    +8     
  Branches      4968     4968           
========================================
+ Hits         33768    33775    +7     
  Misses        5315     5315           
- Partials      1761     1762    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit 12fa376 into develop Sep 24, 2024
34 checks passed
@bmarty bmarty deleted the bma/invitationWithSender branch September 24, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Change For updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants