-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pinned events banner reappearing when loading #3519
Conversation
1fde1ca
to
d28d11a
Compare
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Make the `RustTimelineItem.timelineItems` property a `SharedFlow` so we don't always incorrectly load an empty state by default.
d28d11a
to
749376c
Compare
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3519 +/- ##
========================================
Coverage 82.67% 82.67%
========================================
Files 1731 1731
Lines 40863 40863
Branches 4971 4971
========================================
Hits 33785 33785
Misses 5315 5315
Partials 1763 1763 ☔ View full report in Codecov by Sentry. |
Does this also solve the weirdness I see sometimes that causes the banner to slide in diagonally from the top-left instead of straight down? |
Yes it does! |
Content
Change the
RustTimeline.timelineItems
property from aMutableStateFlow
with an empty list to aMutableSharedFlow
which will be populated with the contents of the Rust SDK timeline as soon as they're available.Motivation and context
Fix an issue where the display animation happened twice when loading items because the first items loaded into the pinned events timeline were an incorrect empty list.
Tests
Tested devices
Checklist