Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinned messages analytics #3523

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Pinned messages analytics #3523

merged 4 commits into from
Sep 24, 2024

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Sep 23, 2024 •
edited
Loading

Content

  • Add some analytics for tracking pinned messages use cases.
  • Introduce LocalAnalyticsService to track ui events more easily directly from views.

Motivation and context

Handles https://github.com/element-hq/element-internal/issues/617

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@ganfra ganfra added the PR-Misc For other changes label Sep 23, 2024
@ganfra ganfra changed the title Feature/fga/pinned messages analytics Pinned messages analytics Sep 23, 2024
@ganfra ganfra marked this pull request as ready for review September 23, 2024 18:53
@ganfra ganfra requested a review from a team as a code owner September 23, 2024 18:53
@ganfra ganfra requested review from jmartinesp and removed request for a team September 23, 2024 18:53
@github-actions GitHub Actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/T7gKHK

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov Codecov
Copy link

codecov bot commented Sep 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.55556% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.68%. Comparing base (dfe9323) to head (269889d).
Report is 29 commits behind head on develop.

Files with missing lines Patch % Lines
...c/main/kotlin/io/element/android/x/MainActivity.kt 0.00% 1 Missing ⚠️
...droid/features/roomdetails/impl/RoomDetailsView.kt 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3523      +/-   ##
===========================================
+ Coverage    82.67%   82.68%   +0.01%     
===========================================
  Files         1731     1732       +1     
  Lines        40844    40873      +29     
  Branches      4968     4968              
===========================================
+ Hits         33768    33797      +29     
+ Misses        5315     5314       -1     
- Partials      1761     1762       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jmartinesp
jmartinesp approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 24, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 24, 2024
bmarty
bmarty reviewed Sep 24, 2024
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait before merging, I want to check something.

bmarty
bmarty reviewed Sep 24, 2024
View reviewed changes
plugins/src/main/kotlin/extension/DependencyHandleScope.kt
@@ -114,6 +114,7 @@ fun DependencyHandlerScope.allServicesImpl() {
// For analytics configuration, either use noop, or use the impl, with at least one analyticsproviders implementation
// implementation(project(":services:analytics:noop"))
implementation(project(":services:analytics:impl"))
implementation(project(":services:analytics:compose"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanting to check how it behaves when not including :services:analytics:impl. It seems to be OK.

I may want to revisit how we include or not modules by creating a configuration file, but I''l do it in antoher PR.

@bmarty bmarty merged commit d4e8488 into develop Sep 24, 2024
34 checks passed
@bmarty bmarty deleted the feature/fga/pinned_messages_analytics branch September 24, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

@jmartinesp jmartinesp jmartinesp approved these changes

Assignees
No one assigned
Labels
PR-Misc For other changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ganfra @jmartinesp @bmarty