-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce ModulesConfig #3530
Introduce ModulesConfig #3530
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3530 +/- ##
===========================================
- Coverage 82.68% 82.68% -0.01%
===========================================
Files 1732 1732
Lines 40904 40904
Branches 4973 4973
===========================================
- Hits 33823 33822 -1
Misses 5316 5316
- Partials 1765 1766 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is quite nice! I wonder if we'd have to tweak it in the future if we want it to work fine with config cache, but config cache is disabled at the moment anyway so I guess we'll cross that bridge when we come to it.
Thanks for the heads-up, looks fine to me 👍 |
Content
Introduce ModulesConfig to be able to customize which modules are included at build time easily.
It may impact how forks are tweaking the application. CC @SpiritCroc
Motivation and context
Avoid mistakes when ading more module and make configuration easier.
Screenshots / GIFs
Tests
Tested devices
Checklist