Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ModulesConfig #3530

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Introduce ModulesConfig #3530

merged 3 commits into from
Sep 25, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Sep 24, 2024

Content

Introduce ModulesConfig to be able to customize which modules are included at build time easily.

It may impact how forks are tweaking the application. CC @SpiritCroc

Motivation and context

Avoid mistakes when ading more module and make configuration easier.

Screenshots / GIFs

Tests

  • Nothing should change for regular EXA.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty added the PR-Build For changes related to build, tools, CI/CD label Sep 24, 2024
@bmarty bmarty requested a review from a team as a code owner September 24, 2024 11:41
@bmarty bmarty requested review from jmartinesp and removed request for a team September 24, 2024 11:41
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/tHNA36

Copy link

sonarcloud bot commented Sep 24, 2024

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.68%. Comparing base (a761a47) to head (4fc1878).
Report is 32 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3530      +/-   ##
===========================================
- Coverage    82.68%   82.68%   -0.01%     
===========================================
  Files         1732     1732              
  Lines        40904    40904              
  Branches      4973     4973              
===========================================
- Hits         33823    33822       -1     
  Misses        5316     5316              
- Partials      1765     1766       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite nice! I wonder if we'd have to tweak it in the future if we want it to work fine with config cache, but config cache is disabled at the moment anyway so I guess we'll cross that bridge when we come to it.

@SpiritCroc
Copy link
Contributor

Thanks for the heads-up, looks fine to me 👍

@bmarty bmarty merged commit e2ab1ef into develop Sep 25, 2024
30 checks passed
@bmarty bmarty deleted the feature/bma/moduleConfig branch September 25, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Build For changes related to build, tools, CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants