Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform the migration, even if the current version is not known. #3535

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Sep 25, 2024

Content

Perform the migration, even if the current version is not known.

It can happen that user has a very old version with a session, and the mechanism to update the internal data did not exist.
If the user upgrade to a recent version, the migrations were skipped and this can make the existing session not recoverable.

For fresh install, all the existing migrations will be no-op, so that's fine.

Motivation and context

Closes #3534

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner September 25, 2024 09:57
@bmarty bmarty requested review from ganfra and removed request for a team September 25, 2024 09:57
Copy link
Contributor

github-actions bot commented Sep 25, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/sCMKgJ

@bmarty bmarty added the PR-Bugfix For bug fix label Sep 25, 2024
@bmarty
Copy link
Member Author

bmarty commented Sep 25, 2024

I confirm that migrating from v0.4.10 is fixing the issue.

The issue was: not restoring the session, and unable to sign in using the same account.
Now: the existing session is migrated and restored, no need to sign in again.

Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check the failing test? Done

@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 25, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 25, 2024
Copy link

sonarcloud bot commented Sep 25, 2024

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.62%. Comparing base (ae7a79e) to head (23ed755).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3535   +/-   ##
========================================
  Coverage    82.62%   82.62%           
========================================
  Files         1732     1732           
  Lines        40939    40939           
  Branches      4980     4980           
========================================
  Hits         33827    33827           
  Misses        5343     5343           
  Partials      1769     1769           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member Author

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the test

@ganfra ganfra merged commit 14dc0da into develop Sep 25, 2024
30 checks passed
@ganfra ganfra deleted the feature/bma/alwaysMigrateApp branch September 25, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stale app data leaves app unable to login (unable to open database file: /matrix-sdk-state.sqlite3)
2 participants