-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perform the migration, even if the current version is not known. #3535
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
I confirm that migrating from The issue was: not restoring the session, and unable to sign in using the same account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check the failing test? Done
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3535 +/- ##
========================================
Coverage 82.62% 82.62%
========================================
Files 1732 1732
Lines 40939 40939
Branches 4980 4980
========================================
Hits 33827 33827
Misses 5343 5343
Partials 1769 1769 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the test
Content
Perform the migration, even if the current version is not known.
It can happen that user has a very old version with a session, and the mechanism to update the internal data did not exist.
If the user upgrade to a recent version, the migrations were skipped and this can make the existing session not recoverable.
For fresh install, all the existing migrations will be no-op, so that's fine.
Motivation and context
Closes #3534
Screenshots / GIFs
Tests
Tested devices
Checklist