Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename invisible flag to onlySignedDeviceIsolation flag #3542

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

BillCarsonFr
Copy link
Member

Fixes #3528

Content

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@BillCarsonFr BillCarsonFr requested a review from a team as a code owner September 25, 2024 21:02
@BillCarsonFr BillCarsonFr requested review from jmartinesp and removed request for a team September 25, 2024 21:02
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/tWoTmw

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.62%. Comparing base (fdd0a0d) to head (10014d3).
Report is 9 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3542   +/-   ##
========================================
  Coverage    82.62%   82.62%           
========================================
  Files         1732     1732           
  Lines        40939    40939           
  Branches      4980     4980           
========================================
  Hits         33827    33827           
  Misses        5343     5343           
  Partials      1769     1769           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Sep 26, 2024

@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 26, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 26, 2024
@ganfra ganfra merged commit 0c10784 into develop Sep 26, 2024
31 checks passed
@ganfra ganfra deleted the feature/valere/rename_invisible_crypto_flag branch September 26, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crypto: Rename Invisible Crypto lab flag
3 participants