-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't display security banner for unknown RecoveryState #3579
Don't display security banner for unknown RecoveryState #3579
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense, thanks. A bit too many preview states added :)
aSecureBackupRootState(backupState = BackupState.WAITING_FOR_SYNC), | ||
aSecureBackupRootState(backupState = BackupState.CREATING), | ||
aSecureBackupRootState(backupState = BackupState.RESUMING), | ||
aSecureBackupRootState(backupState = BackupState.RESUMING), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a duplicated case here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooops, too many Cmd+D
. Good catch!
aSecureBackupRootState(backupState = BackupState.RESUMING), | ||
aSecureBackupRootState(backupState = BackupState.DOWNLOADING), | ||
aSecureBackupRootState(backupState = BackupState.DISABLING), | ||
aSecureBackupRootState(backupState = BackupState.ENABLED), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here too.
2d8fe60
to
542c75b
Compare
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3579 +/- ##
========================================
Coverage 82.69% 82.70%
========================================
Files 1732 1732
Lines 40977 40982 +5
Branches 4964 4964
========================================
+ Hits 33886 33894 +8
+ Misses 5337 5333 -4
- Partials 1754 1755 +1 ☔ View full report in Codecov by Sentry. |
Content
Motivation and context
@bnjbvr reported this bug found when the device couldn't correctly connect to the HS.
Screenshots / GIFs
In the PR.
Tests
The bug report says the device couldn't reach the server but the device had internet connectivity, so maybe block your HS address in your network temporarily or enable a proxy that doesn't connect to the HS.
Tested devices
Checklist