Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't display security banner for unknown RecoveryState #3579

Conversation

jmartinesp
Copy link
Member

Content

  • Prevents the 'set up recovery' banner from being displayed in the room list when the recovery state is unknown.
  • Also prevents the UI for setting up the recovery from appearing in the chat backup options when the recovery state is unknown.
  • Added some more screenshots to verify the different states.

Motivation and context

@bnjbvr reported this bug found when the device couldn't correctly connect to the HS.

Screenshots / GIFs

In the PR.

Tests

The bug report says the device couldn't reach the server but the device had internet connectivity, so maybe block your HS address in your network temporarily or enable a proxy that doesn't connect to the HS.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@jmartinesp jmartinesp added the PR-Bugfix For bug fix label Oct 2, 2024
@jmartinesp jmartinesp requested a review from a team as a code owner October 2, 2024 08:03
@jmartinesp jmartinesp requested review from ganfra and removed request for a team October 2, 2024 08:03
Copy link
Contributor

github-actions bot commented Oct 2, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/XQjbTV

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense, thanks. A bit too many preview states added :)

aSecureBackupRootState(backupState = BackupState.WAITING_FOR_SYNC),
aSecureBackupRootState(backupState = BackupState.CREATING),
aSecureBackupRootState(backupState = BackupState.RESUMING),
aSecureBackupRootState(backupState = BackupState.RESUMING),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a duplicated case here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops, too many Cmd+D. Good catch!

aSecureBackupRootState(backupState = BackupState.RESUMING),
aSecureBackupRootState(backupState = BackupState.DOWNLOADING),
aSecureBackupRootState(backupState = BackupState.DISABLING),
aSecureBackupRootState(backupState = BackupState.ENABLED),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here too.

@jmartinesp jmartinesp force-pushed the fix/jme/do-not-display-security-banner-for-unknown-recovery-state branch from 2d8fe60 to 542c75b Compare October 2, 2024 08:10
@jmartinesp jmartinesp added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Oct 2, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Oct 2, 2024
Copy link

sonarcloud bot commented Oct 2, 2024

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.70%. Comparing base (1d5509e) to head (e48d3ef).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3579   +/-   ##
========================================
  Coverage    82.69%   82.70%           
========================================
  Files         1732     1732           
  Lines        40977    40982    +5     
  Branches      4964     4964           
========================================
+ Hits         33886    33894    +8     
+ Misses        5337     5333    -4     
- Partials      1754     1755    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 2, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 2, 2024
@jmartinesp jmartinesp enabled auto-merge (squash) October 2, 2024 09:02
@jmartinesp jmartinesp merged commit f344a12 into develop Oct 2, 2024
30 checks passed
@jmartinesp jmartinesp deleted the fix/jme/do-not-display-security-banner-for-unknown-recovery-state branch October 2, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants