Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline better jump to behaviours #3597

Merged
merged 5 commits into from
Oct 3, 2024

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Oct 3, 2024

Content

Improve behaviours of permalink navigation it includes :

  • TypingNotification is now part of the timelineItems so indexes are correct
  • Synchronisation around timeline indexer
  • Center focused item on the view port if possible
  • Fix jump to bottom when timeline is not live

Motivation and context

Replaces #3556
Fixes #2775

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@ganfra ganfra added the PR-Misc For other changes label Oct 3, 2024
@ganfra ganfra marked this pull request as ready for review October 3, 2024 13:38
@ganfra ganfra requested a review from a team as a code owner October 3, 2024 13:38
@ganfra ganfra requested review from jmartinesp and bmarty and removed request for a team October 3, 2024 13:38
Copy link
Contributor

github-actions bot commented Oct 3, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Dzu9ZK

Copy link

sonarcloud bot commented Oct 3, 2024

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 68.65672% with 21 lines in your changes missing coverage. Please review.

Project coverage is 81.34%. Comparing base (f8fa218) to head (adc03c9).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
...roid/libraries/designsystem/utils/LazyListState.kt 43.75% 5 Missing and 4 partials ⚠️
...id/features/messages/impl/timeline/TimelineView.kt 55.55% 2 Missing and 2 partials ⚠️
...impl/timeline/components/TimelineItemVirtualRow.kt 0.00% 3 Missing ⚠️
...atures/messages/impl/timeline/TimelinePresenter.kt 91.66% 1 Missing ⚠️
...d/features/messages/impl/timeline/TimelineState.kt 80.00% 0 Missing and 1 partial ⚠️
...ne/factories/virtual/TimelineItemVirtualFactory.kt 0.00% 1 Missing ⚠️
...del/virtual/TimelineItemTypingNotificationModel.kt 0.00% 1 Missing ⚠️
...x/api/timeline/item/virtual/VirtualTimelineItem.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3597      +/-   ##
===========================================
- Coverage    81.71%   81.34%   -0.38%     
===========================================
  Files         1751     1757       +6     
  Lines        41936    42448     +512     
  Branches      5071     5077       +6     
===========================================
+ Hits         34269    34528     +259     
- Misses        5893     6140     +247     
- Partials      1774     1780       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the changes LGTM and it works quite well.

@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 3, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 3, 2024
@ganfra ganfra enabled auto-merge October 3, 2024 14:56
@ganfra ganfra merged commit c1337de into develop Oct 3, 2024
32 of 34 checks passed
@ganfra ganfra deleted the feature/fga/timeline_better_jump_to_behaviours branch October 3, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jumping to a message may not bring it into view
2 participants