Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency: Bump rust sdk to 0.2.51 #3602

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

BillCarsonFr
Copy link
Member

Bumps rust-sdk to latest main.

Content

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@BillCarsonFr BillCarsonFr requested a review from a team as a code owner October 4, 2024 09:51
@BillCarsonFr BillCarsonFr requested review from ganfra and removed request for a team October 4, 2024 09:51
@BillCarsonFr BillCarsonFr added the PR-Dependencies Pull requests that update a dependency file label Oct 4, 2024
Copy link
Contributor

github-actions bot commented Oct 4, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/yS6nv4

Copy link

sonarcloud bot commented Oct 4, 2024

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.63%. Comparing base (c1337de) to head (2230163).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3602      +/-   ##
===========================================
- Coverage    82.15%   81.63%   -0.52%     
===========================================
  Files         1747     1761      +14     
  Lines        42740    43022     +282     
  Branches      5068     5103      +35     
===========================================
+ Hits         35111    35121      +10     
- Misses        5841     6096     +255     
- Partials      1788     1805      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 4, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 4, 2024
@BillCarsonFr BillCarsonFr merged commit 8021261 into develop Oct 4, 2024
32 of 33 checks passed
@BillCarsonFr BillCarsonFr deleted the feature/valere/bump_rust_sdk_0.2.51 branch October 4, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants