Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building the app using a local SDK. #3604

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 4, 2024

Inject AnalyticsService instead of UtdTracker since UtdTracker requires access to org.matrix.rustcomponents.sdk.UnableToDecryptDelegate.

Inject `AnalyticsService` instead of `UtdTracker` since `UtdTracker` requires access to `org.matrix.rustcomponents.sdk.UnableToDecryptDelegate`
@bmarty bmarty requested a review from a team as a code owner October 4, 2024 10:03
@bmarty bmarty requested review from ganfra and removed request for a team October 4, 2024 10:03
@bmarty bmarty added the PR-Misc For other changes label Oct 4, 2024
Copy link
Contributor

github-actions bot commented Oct 4, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/NjrDtZ

Copy link

sonarcloud bot commented Oct 4, 2024

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.06%. Comparing base (c1337de) to head (1e91e8b).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3604      +/-   ##
===========================================
- Coverage    82.15%   82.06%   -0.09%     
===========================================
  Files         1747     1752       +5     
  Lines        42740    42149     -591     
  Branches      5068     5046      -22     
===========================================
- Hits         35111    34589     -522     
+ Misses        5841     5778      -63     
+ Partials      1788     1782       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit 05a6a3b into develop Oct 4, 2024
29 of 30 checks passed
@bmarty bmarty deleted the feature/bma/fixBuildWithLocalSdk branch October 4, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants