Fix screenshot recording in CI

[jmartinesp]

Content

Fix recording screenshots flow.

Motivation and context

The --no-configuration-cache was added in the wrong place, it's a gradle argument, not a jvm option.

Screenshots / GIFs

It somehow deleted some screenshots, which scares me a bit.

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/xwjGSw

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.68%. Comparing base (05a6a3b) to head (02a173f).
Report is 6 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3607   +/-   ##
========================================
  Coverage    82.68%   82.68%           
========================================
  Files         1731     1731           
  Lines        41008    41008           
  Branches      4973     4973           
========================================
  Hits         33906    33906           
  Misses        5342     5342           
  Partials      1760     1760           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jmartinesp]

The tests passed, so I guess deleting those screenshots was the right thing for the flow to do.

[bmarty]

The tests passed, so I guess deleting those screenshots was the right thing for the flow to do.

Yes, the Preview has been removed here: https://github.com/element-hq/element-x-android/pull/3597/files#diff-50bc7833b8f4ad56f8bf8ac0ce9b0b5e055250aeb602115fa22666b858a4493f but since the screenshots has not been recorded on this PR, the screenshot files have not been removed.