Fix the logic of the room list banner state

[jmartinesp]

Content

• Make sure needsSlidingSyncMigration also generates a state for derivedStateOf.
• Fix the logic in the derivedStateOf block: it fixes an issue that hid the migration banner, gets rid of the syncState and can now be extended with more cases that fallthrough to the next ones.

Motivation and context

Fix the migration banner not being displayed in some cases that @pixlwave reported. To be honest I have no idea why this issue appeared now, since it was tested several times before and it worked as expected. Maybe an update of the compose compiler broke it?

Tests

• Log into a HS with both SS and SSS support, with sliding sync disabled in the app (I used riot.grin.hu).
• Check the upgrade banner appears.
• It can be dismissed.
• When restarting the app, the banner is displayed again.

Tested devices

• Physical
• Emulator
• OS version(s): 14

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/NV4aLD

[codecov]

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.65%. Comparing base (409564a) to head (230abd3).
Report is 1 commits behind head on develop.

Files with missing lines	Patch %	Lines
...ndroid/features/roomlist/impl/RoomListPresenter.kt	86.66%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3615   +/-   ##
========================================
  Coverage    82.65%   82.65%           
========================================
  Files         1735     1735           
  Lines        41187    41191    +4     
  Branches      5000     4999    -1     
========================================
+ Hits         34043    34047    +4     
- Misses        5380     5381    +1     
+ Partials      1764     1763    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ganfra]

Is it not because needsSlidingSyncMigration needs to be wrapped in a state like securityBannerDismissed, with rememberUpdatedState?

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[ganfra]

LGTM, thanks

[bmarty]

(For later) RoomListPresenter is quite a large file, so maybe this logic could be extracted and covered by a few unit tests?

Edit: we can see that a case is missing in the coverage, and unit test will also check the "priority" of the parameters: