Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not render pin violation in clear rooms. #3630

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 8, 2024

Content

Do not listen to identity change in clear rooms.

Motivation and context

Android part of element-hq/element-meta#2560

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner October 8, 2024 16:31
@bmarty bmarty requested review from jmartinesp and removed request for a team October 8, 2024 16:31
Copy link

sonarcloud bot commented Oct 8, 2024

Copy link
Contributor

github-actions bot commented Oct 8, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/YcFN4Q

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.70%. Comparing base (0ffd787) to head (ef4aa8f).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...pl/crypto/identity/IdentityChangeStatePresenter.kt 87.50% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3630   +/-   ##
========================================
  Coverage    82.70%   82.70%           
========================================
  Files         1744     1744           
  Lines        41338    41347    +9     
  Branches      5015     5015           
========================================
+ Hits         34188    34198   +10     
  Misses        5377     5377           
+ Partials      1773     1772    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty changed the title Do not render pin violation in clear room. Do not render pin violation in clear rooms. Oct 9, 2024
@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 9, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 9, 2024
@bmarty bmarty merged commit 44dc004 into develop Oct 9, 2024
31 checks passed
@bmarty bmarty deleted the feature/bma/noIdentityChangeAlertInClearRoom branch October 9, 2024 07:10
Copy link
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

// No item emitted.
expectNoEvents()
// Room become encrypted.
room.enableEncryption()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants