-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not render pin violation in clear rooms. #3630
Conversation
Quality Gate passedIssues Measures |
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3630 +/- ##
========================================
Coverage 82.70% 82.70%
========================================
Files 1744 1744
Lines 41338 41347 +9
Branches 5015 5015
========================================
+ Hits 34188 34198 +10
Misses 5377 5377
+ Partials 1773 1772 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
// No item emitted. | ||
expectNoEvents() | ||
// Room become encrypted. | ||
room.enableEncryption() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice test!
Content
Do not listen to identity change in clear rooms.
Motivation and context
Android part of element-hq/element-meta#2560
Screenshots / GIFs
Tests
Tested devices
Checklist