Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QrCode intro screen: add subtitle and fix button wording #3632 #3633

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 9, 2024

Content

Add subtitle and fix button wording.

Motivation and context

Closes #3632

Screenshots / GIFs

See recorded one

Tests

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner October 9, 2024 09:26
@bmarty bmarty requested review from ganfra and removed request for a team October 9, 2024 09:26
@bmarty bmarty added the PR-Misc For other changes label Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/GzgKr4

Copy link

sonarcloud bot commented Oct 9, 2024

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 9, 2024
@bmarty bmarty enabled auto-merge October 9, 2024 09:51
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.71%. Comparing base (47dcdef) to head (bf13341).
Report is 10 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3633   +/-   ##
========================================
  Coverage    82.71%   82.71%           
========================================
  Files         1744     1744           
  Lines        41347    41348    +1     
  Branches      5015     5015           
========================================
+ Hits         34199    34200    +1     
  Misses        5377     5377           
  Partials      1771     1771           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit 79a1ab7 into develop Oct 9, 2024
30 checks passed
@bmarty bmarty deleted the feature/bma/qrCodeNotice branch October 9, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Show a hint that QR code login is only available when the account provider supports.
3 participants