AsyncAction confirming with param

[bmarty]

Content

• Let AsyncAction.Confirming be an interface, with a AsyncAction.ConfirmingNoParams data object.
  This will allow inheritance of AsyncAction.Confirming with parameter(s).
• AcceptDeclineInviteState: create ConfirmingDeclineInvite to host InviteData when confirming decline of invite.

Replacement for #3645 (other change from #3645 will be in separate PRs.)
Can be reviewed commit per commit

Motivation and context

Improve code when confirmation need data to be rendered.

Screenshots / GIFs

Tests

• No behavior change.

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/FwrZ7D

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

Attention: Patch coverage is 90.90909% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.81%. Comparing base (792fdb3) to head (ca4f906).
Report is 29 commits behind head on develop.

Files with missing lines	Patch %	Lines
...es/invite/impl/response/AcceptDeclineInviteView.kt	50.00%	1 Missing and 1 partial ⚠️
...d/features/lockscreen/impl/unlock/PinUnlockView.kt	0.00%	0 Missing and 1 partial ⚠️
...mbers/moderation/RoomMembersModerationPresenter.kt	50.00%	1 Missing ⚠️
...atures/verifysession/impl/VerifySelfSessionView.kt	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3667      +/-   ##
===========================================
- Coverage    82.81%   82.81%   -0.01%     
===========================================
  Files         1747     1748       +1     
  Lines        41779    41771       -8     
  Branches      5107     5106       -1     
===========================================
- Hits         34599    34592       -7     
  Misses        5365     5365              
+ Partials      1815     1814       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jmartinesp]

LGTM, just a comment.

[jmartinesp]

Can't we just force cast it then?

[bmarty]

We could but why take the risk of a crash?
Previous code was not val invite = state.invite!!, so I prefer to keep the code safe.

[jmartinesp]

We could but why take the risk of a crash?

Can we then log an error or upload some error report to sentry? I'm worried this might just silently fail, although the tests should cover it.

[bmarty]

My previous attempt to fix this would have avoid this drawback. But it was too invasive, so we go with this approach. This is not a new issue, so I guess this is fine.