-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve room moderation #3671
Improve room moderation #3671
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
88b41ce
to
b518c83
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3671 +/- ##
===========================================
+ Coverage 82.80% 82.81% +0.01%
===========================================
Files 1749 1750 +1
Lines 41840 41860 +20
Branches 5114 5117 +3
===========================================
+ Hits 34644 34665 +21
Misses 5381 5381
+ Partials 1815 1814 -1 ☔ View full report in Codecov by Sentry. |
2fb650f
to
c66802b
Compare
…nban action. Better to keep a generic name, in case this class is used for any other action.
Quality Gate passedIssues Measures |
Improve distinction between the action of unbanning a user, which is rendered in a simple dialog, and doing other member moderation, which are rendered in a bottom sheet, thanks to the usage of
selectedMember
. The code is still a bit confusing, I hope this is better than before though.As a drawback, we are loosing a preview of unbanning a user, since the Loading state cannot trigger the display of the banner anymore.