Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve room moderation #3671

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Improve room moderation #3671

merged 3 commits into from
Oct 16, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 14, 2024

Improve distinction between the action of unbanning a user, which is rendered in a simple dialog, and doing other member moderation, which are rendered in a bottom sheet, thanks to the usage of selectedMember. The code is still a bit confusing, I hope this is better than before though.

As a drawback, we are loosing a preview of unbanning a user, since the Loading state cannot trigger the display of the banner anymore.

@bmarty bmarty changed the base branch from develop to feature/bma/asyncActionConfirmingWithParam October 14, 2024 10:40
@bmarty bmarty added the PR-Misc For other changes label Oct 14, 2024
Copy link
Contributor

github-actions bot commented Oct 14, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/7gqUEr

Base automatically changed from feature/bma/asyncActionConfirmingWithParam to develop October 15, 2024 10:28
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 82.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 82.81%. Comparing base (9dc58fc) to head (b33b423).
Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
...mbers/moderation/RoomMembersModerationPresenter.kt 88.88% 0 Missing and 3 partials ⚠️
...pl/members/moderation/RoomMembersModerationView.kt 66.66% 1 Missing and 2 partials ⚠️
...ndroid/libraries/matrix/ui/room/MatrixRoomState.kt 70.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3671      +/-   ##
===========================================
+ Coverage    82.80%   82.81%   +0.01%     
===========================================
  Files         1749     1750       +1     
  Lines        41840    41860      +20     
  Branches      5114     5117       +3     
===========================================
+ Hits         34644    34665      +21     
  Misses        5381     5381              
+ Partials      1815     1814       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…nban action. Better to keep a generic name, in case this class is used for any other action.
@bmarty bmarty marked this pull request as ready for review October 16, 2024 09:59
@bmarty bmarty requested a review from a team as a code owner October 16, 2024 09:59
@bmarty bmarty requested review from ganfra and removed request for a team October 16, 2024 09:59
Copy link

sonarcloud bot commented Oct 16, 2024

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 16, 2024
@bmarty bmarty enabled auto-merge October 16, 2024 15:13
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 16, 2024
@bmarty bmarty disabled auto-merge October 16, 2024 15:57
@bmarty bmarty merged commit f95ab1f into develop Oct 16, 2024
28 of 29 checks passed
@bmarty bmarty deleted the bma/improveRoomModeration branch October 16, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants