-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup tests #3672
Cleanup tests #3672
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3672 +/- ##
========================================
Coverage 82.81% 82.81%
========================================
Files 1748 1748
Lines 41777 41778 +1
Branches 5108 5108
========================================
+ Hits 34597 34598 +1
Misses 5365 5365
Partials 1815 1815 ☔ View full report in Codecov by Sentry. |
9a6dc6b
to
2695513
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! I knew there must be a better alternative to the runBlocking
usage, but it never occurred to me simulateLongTask
would help here.
I think this causes flaky tests now 🫤 : https://github.com/element-hq/element-x-android/actions/runs/11373130975/job/31639020847?pr=3697
|
:/. The |
@jmartinesp #3717 should fix flaky test 🤞 |
Remove runBlocking usage in LambdaRecorder.
Protect usage of logoutUseCase.
Let FakeKnockRoom and FakeLogoutUseCase use simulateLongTask, to catch more states.