-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve preview provider name consistency #3673
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3673 +/- ##
===========================================
- Coverage 82.80% 82.79% -0.01%
===========================================
Files 1749 1749
Lines 41835 41835
Branches 5113 5113
===========================================
- Hits 34640 34639 -1
Misses 5380 5380
- Partials 1815 1816 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd prefer to use PreviewProvider
instead, but as you want.
…end with 'Provider' and MUST contain provided class name`
…g to the new naming convention. `Provider` suffix is enough and more used than `PreviewProvider`, so let's make the codebase more consistent.
e561c11
to
6e27266
Compare
Yes, that's probably better but it would require to change much more classes. Also those classes do not provide Preview but States, so naming them |
Quality Gate passedIssues Measures |
Content
Rename some classes which implement PreviewParameterProvider according to the new naming convention.
Provider
suffix is enough and more used thanPreviewProvider
, so let's make the codebase more consistent.Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist