Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update store description #3680

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Update store description #3680

merged 2 commits into from
Oct 15, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 15, 2024

Content

Fix typo (thanks @Hywan !) and add rationale for permissions.

Motivation and context

Will fix typo in the store description, at https://f-droid.org/packages/io.element.android.x/ and https://play.google.com/store/apps/details?id=io.element.android.x

Screenshots / GIFs

Tests

  • No change

Tested devices

  • NA

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner October 15, 2024 06:57
@bmarty bmarty requested review from jmartinesp and removed request for a team October 15, 2024 06:57
@bmarty bmarty added the PR-Doc For updates to the documentation label Oct 15, 2024
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Dg3P6e

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment on lines +37 to +39

The application requires the USE_FULL_SCREEN_INTENT permission to ensure our users can effectively receive call notifications even when their devices are locked.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this part required now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already live on the PlayStore and yes, it was required by Google. I forgot to add this part when importing the new description, and it's better to stay synced with what on the PlayStore. One day (probably when we will start translating this) publication will be automated as it was the case on EA.

Copy link

sonarcloud bot commented Oct 15, 2024

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.81%. Comparing base (ed9046f) to head (67f1752).
Report is 9 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3680   +/-   ##
========================================
  Coverage    82.81%   82.81%           
========================================
  Files         1747     1747           
  Lines        41780    41780           
  Branches      5107     5107           
========================================
  Hits         34599    34599           
  Misses        5365     5365           
  Partials      1816     1816           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit 830304f into develop Oct 15, 2024
30 checks passed
@bmarty bmarty deleted the feature/bma/storeDescription branch October 15, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Doc For updates to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants