RTL: ensure sender information are correctly rendered in the timeline #3681
Conversation
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3681 +/- ##
===========================================
- Coverage 82.81% 82.81% -0.01%
===========================================
Files 1747 1747
Lines 41785 41789 +4
Branches 5109 5111 +2
===========================================
+ Hits 34604 34607 +3
Misses 5365 5365
- Partials 1816 1817 +1 ☔ View full report in Codecov by Sentry. |
| ) | ||
| .clip(bubbleShape) | ||
| .combinedClickable( | ||
| onClick = onClick, | ||
| onLongClick = onLongClick, | ||
| indication = ripple(), | ||
| interactionSource = interactionSource | ||
| ), | ||
| ) | ||
| .onGloballyPositioned { coordinates -> |
There was a problem hiding this comment.
Using onGloballyPositioned is not really great for performance, also we already have the size in the drawWithContent scope.
| @@ -112,7 +120,7 @@ fun MessageEventBubble( | |||
| drawCircle( | |||
| color = Color.Black, | |||
| center = Offset( | |||
| x = 0f, | |||
| x = if (isRtl) contentWidthPx else 0f, | |||
There was a problem hiding this comment.
Just x = if(isRtl) size.width else 0f should be good!
There was a problem hiding this comment.
Of course, I do not know why I did not see that yesterday. Thanks!
|
Content
Sender information must be rendered at top start of the bubble.
In RTL, the cropping of the bubble was not correct (first commit) and the sender info was not aligned correctly (second commit)
Motivation and context
Second point of #2865
Screenshots / GIFs
From
TimelineItemEventRowTimestampPreview:Tests
Tested devices
Checklist