Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add userId in identity change warning banner #3686

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 15, 2024

Content

Ensure userId is displayed in the warning about identity changed banner.

Motivation and context

Closes #3678

Screenshots / GIFs

See the recorded ones.

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner October 15, 2024 16:14
@bmarty bmarty requested review from ganfra and removed request for a team October 15, 2024 16:14
Copy link
Contributor

github-actions bot commented Oct 15, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/15Rk8i

Copy link

sonarcloud bot commented Oct 16, 2024

@bmarty bmarty added the PR-Change For updates to an existing feature label Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 91.89189% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.81%. Comparing base (717d1b2) to head (6392404).
Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
...mpl/crypto/identity/IdentityChangeStateProvider.kt 85.71% 2 Missing ⚠️
...nt/android/libraries/matrix/api/room/RoomMember.kt 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3686   +/-   ##
========================================
  Coverage    82.81%   82.81%           
========================================
  Files         1748     1748           
  Lines        41777    41804   +27     
  Branches      5108     5109    +1     
========================================
+ Hits         34597    34622   +25     
- Misses        5365     5366    +1     
- Partials      1815     1816    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit ce318b3 into develop Oct 16, 2024
29 checks passed
@bmarty bmarty deleted the feature/bma/identityChangeWording branch October 16, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Change For updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Missing mxId in the Banner for unverified user identity change
3 participants