Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: fix list item colors #3706

Merged
merged 5 commits into from
Oct 21, 2024
Merged

UI: fix list item colors #3706

merged 5 commits into from
Oct 21, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 18, 2024

Content

Add more screenshots on ListItem and fix issue with colors.

Motivation and context

Disabled ListItem with Destructive style was not rendered correctly.

Screenshots / GIFs

Tests

Screenshot test

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner October 18, 2024 14:33
@bmarty bmarty requested review from ganfra and removed request for a team October 18, 2024 14:33
@bmarty bmarty changed the title Bma/list item fixes UI: fix list item colors Oct 18, 2024
@bmarty bmarty added the PR-Bugfix For bug fix label Oct 18, 2024
Copy link
Contributor

github-actions bot commented Oct 18, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/8oWC5f

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.02%. Comparing base (b0df319) to head (3094e47).
Report is 14 commits behind head on develop.

Files with missing lines Patch % Lines
...ibraries/designsystem/theme/components/ListItem.kt 93.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3706   +/-   ##
========================================
  Coverage    83.02%   83.02%           
========================================
  Files         1752     1752           
  Lines        43780    43790   +10     
  Branches      5121     5122    +1     
========================================
+ Hits         36347    36357   +10     
- Misses        5612     5613    +1     
+ Partials      1821     1820    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 21, 2024

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 21, 2024
@bmarty bmarty enabled auto-merge October 21, 2024 08:58
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 21, 2024
@bmarty bmarty disabled auto-merge October 21, 2024 09:14
@bmarty bmarty merged commit 5b32fd8 into develop Oct 21, 2024
29 of 30 checks passed
@bmarty bmarty deleted the bma/listItemFixes branch October 21, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants