Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import path broken in module template #3710

Merged

Conversation

torrybr
Copy link
Contributor

@torrybr torrybr commented Oct 19, 2024

Content

fix import extensions.setupAnvil so that it using correct extension.setupAnvil and correct template of feature_module_name in api() import

Motivation and context

Im using the developer onboarding docs and creating a new feature module from the template, but it doesn't generate an error free module because of a bad import and template issue.

Tests

  • Follow onboarding docs for creating a new feature module from a template

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

Signed-off-by: Torry Brelsford tb@brehl.dev

@torrybr torrybr requested a review from a team as a code owner October 19, 2024 14:28
@torrybr torrybr requested review from jmartinesp and removed request for a team October 19, 2024 14:28
@CLAassistant
Copy link

CLAassistant commented Oct 19, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

  • Your branch should be based on origin/develop, at least when it was created.
  • The title of the PR will be used for release notes, so it needs to describe the change visible to the user.
  • The test pass locally running ./gradlew test.
  • The code quality check suite pass locally running ./gradlew runQualityChecks.
  • If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and sorry for the typo that caused the issue!

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.01%. Comparing base (714f74a) to head (2b789d3).
Report is 15 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3710      +/-   ##
===========================================
- Coverage    83.02%   83.01%   -0.01%     
===========================================
  Files         1752     1752              
  Lines        43772    43772              
  Branches      5121     5121              
===========================================
- Hits         36341    36337       -4     
- Misses        5610     5611       +1     
- Partials      1821     1824       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty added the Z-Community-PR Issue is solved by a community member's PR label Oct 21, 2024
@jmartinesp jmartinesp added the PR-Build For changes related to build, tools, CI/CD label Oct 21, 2024
@jmartinesp jmartinesp changed the title fix: import path broken and api dependency format fix: import path broken in module template Oct 21, 2024
@jmartinesp
Copy link
Member

Could you also sign the CLA? It's one of the required steps to contribute.

@torrybr
Copy link
Contributor Author

torrybr commented Oct 21, 2024

Could you also sign the CLA? It's one of the required steps to contribute.

Signed, thanks!

@jmartinesp jmartinesp merged commit 804506b into element-hq:develop Oct 21, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Build For changes related to build, tools, CI/CD Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants