Verified user badge #3718

bmarty · 2024-10-22T08:45:46Z

Content

Show a "Verified" badge in room member detail page when the user is verified. If the user is not verified, show a disabled action to inform the user that they must use another client to verify a user.

First commits are extraction of UI component MatrixBadge and creation of MatrixBadgeRowMolecule.

Motivation and context

Closes #3684

Screenshots / GIFs

See recorded one

Tests

Open room member page for verified user and not verified user and observe the content.

Tested devices

Physical
Emulator
OS version(s):

Checklist

Changes have been tested on an Android device or Android emulator with API 23
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request title will be used in the release note, it clearly define what will change for the user
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off
You've made a self review of your PR

…e module `:features:userprofile:shared`

bmarty · 2024-10-22T08:46:48Z

...s/uitests/src/test/snapshots/images/features.userprofile.shared_UserProfileView_Day_0_en.png

Oups, let me check what happened here (I am rebasing too many times this branch...)

github-actions · 2024-10-22T08:51:53Z

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/n99Sgb

bmarty · 2024-10-22T09:26:16Z

...d/src/main/kotlin/io/element/android/features/userprofile/shared/UserProfileStateProvider.kt

            aUserProfileState(startDmActionState = AsyncAction.Loading),
            aUserProfileState(canCall = true),
-            aUserProfileState(dmRoomId = null),


This state was the same than the first one, so I removed it.

bmarty · 2024-10-22T09:27:16Z

...src/main/kotlin/io/element/android/libraries/matrix/impl/encryption/RustEncryptionService.kt

+    private suspend fun getUserIdentity(userId: UserId): UserIdentity {
+        return service.userIdentity(
+            userId = userId.value,
+            // requestFromHomeserverIfNeeded = true,


This param will come later.

Actually no, I'll cleanup later.

Add disable action to verify user.

codecov · 2024-10-23T06:55:45Z

Codecov Report

Attention: Patch coverage is 98.07692% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.05%. Comparing base (1bfa43b) to head (4820cd0).
Report is 22 commits behind head on develop.

Files with missing lines	Patch %	Lines
...droid/features/roomdetails/impl/RoomDetailsView.kt	97.22%	0 Missing and 1 partial ⚠️
...oid/features/userprofile/shared/UserProfileView.kt	90.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3718      +/-   ##
===========================================
+ Coverage    83.02%   83.05%   +0.02%     
===========================================
  Files         1752     1753       +1     
  Lines        43787    43839      +52     
  Branches      5122     5129       +7     
===========================================
+ Hits         36355    36409      +54     
  Misses        5611     5611              
+ Partials      1821     1819       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ganfra

Some small remarks otherwise LGTM!

ganfra · 2024-10-23T08:39:24Z

...ls/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/RoomDetailsPresenter.kt

@@ -112,6 +113,21 @@ class RoomDetailsPresenter @Inject constructor(

        val roomNotificationSettingsState by room.roomNotificationSettingsStateFlow.collectAsState()

+        val roomBadges by produceState(persistentListOf(), isPublic) {


If the room becomes encrypted this won't be refreshed.
I'd instead use a computed property on RoomDetailsState as we already have all the data we need in the state

If the room becomes encrypted this won't be refreshed.

I have seen that. We need isEncrypted property to be added in RoomInfo for fix that properly across the application.

Done in 35867f9

ganfra · 2024-10-23T08:40:39Z

...details/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/RoomDetailsView.kt

-                    type = RoomBadge.Type.Neutral,
-                )
-            }
+    if (roomBadge.isEmpty()) return


Good practice is to let a Composable function always have at least a root, so I'd just wrap this code in a Box

sonarcloud · 2024-10-23T11:32:17Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ganfra

Thanks for the changes!

bmarty and others added 4 commits October 22, 2024 10:18

Move RoomBadge to atomic package and rename to MatrixBadge

77b87af

Change model and create MatrixBadgeRowMolecule

1ca8c51

Remove unnecessary padding, the Column already have a padding.

ddf4c6d

Move strings with key starting by screen_room_member_details_ to th…

8efbd67

…e module `:features:userprofile:shared`

bmarty requested a review from a team as a code owner October 22, 2024 08:45

bmarty requested review from ganfra and removed request for a team October 22, 2024 08:45

bmarty commented Oct 22, 2024

View reviewed changes

bmarty marked this pull request as draft October 22, 2024 08:47

bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Oct 22, 2024

github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Oct 22, 2024

bmarty added the PR-Feature For a new feature label Oct 22, 2024

bmarty commented Oct 22, 2024

View reviewed changes

bmarty and others added 3 commits October 22, 2024 14:09

Verified user badge.

5378c4e

Add disable action to verify user.

Room badge: let the presenter compute the list of badges.

ecbf6b7

Update screenshots

596fe5e

bmarty force-pushed the feature/bma/verifiedUserBadge branch from 4dcd271 to 596fe5e Compare October 22, 2024 12:10

Code quality

3c23555

bmarty marked this pull request as ready for review October 22, 2024 12:19

bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 23, 2024

github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 23, 2024

ganfra approved these changes Oct 23, 2024

View reviewed changes

bmarty added 4 commits October 23, 2024 12:59

Let roomBadges be a computed val of RoomDetailsState

35867f9

Ensure modifier of BadgeList is used.

2eec17f

Change a preview to have a room detail state without any badge.

f516c09

Fix preview for ignore user in a DM case.

67efecd

bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Oct 23, 2024

github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Oct 23, 2024

Update screenshots

4820cd0

ganfra approved these changes Oct 23, 2024

View reviewed changes

bmarty merged commit 95d95d4 into develop Oct 23, 2024
26 checks passed

bmarty deleted the feature/bma/verifiedUserBadge branch October 23, 2024 12:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Verified user badge #3718

Verified user badge #3718

bmarty commented Oct 22, 2024

bmarty Oct 22, 2024

github-actions bot commented Oct 22, 2024 •

edited

Loading

bmarty Oct 22, 2024

bmarty Oct 22, 2024

bmarty Oct 22, 2024

codecov bot commented Oct 23, 2024 •

edited

Loading

ganfra left a comment

ganfra Oct 23, 2024

bmarty Oct 23, 2024

bmarty Oct 23, 2024 •

edited

Loading

ganfra Oct 23, 2024

bmarty Oct 23, 2024 •

edited

Loading

sonarcloud bot commented Oct 23, 2024

ganfra left a comment

		@@ -112,6 +113,21 @@ class RoomDetailsPresenter @Inject constructor(

		val roomNotificationSettingsState by room.roomNotificationSettingsStateFlow.collectAsState()

		val roomBadges by produceState(persistentListOf(), isPublic) {

Verified user badge #3718

Verified user badge #3718

Conversation

bmarty commented Oct 22, 2024

Content

Motivation and context

Screenshots / GIFs

Tests

Tested devices

Checklist

bmarty Oct 22, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 22, 2024 • edited Loading

bmarty Oct 22, 2024

Choose a reason for hiding this comment

bmarty Oct 22, 2024

Choose a reason for hiding this comment

bmarty Oct 22, 2024

Choose a reason for hiding this comment

codecov bot commented Oct 23, 2024 • edited Loading

Codecov Report

ganfra left a comment

Choose a reason for hiding this comment

ganfra Oct 23, 2024

Choose a reason for hiding this comment

bmarty Oct 23, 2024

Choose a reason for hiding this comment

bmarty Oct 23, 2024 • edited Loading

Choose a reason for hiding this comment

ganfra Oct 23, 2024

Choose a reason for hiding this comment

bmarty Oct 23, 2024 • edited Loading

Choose a reason for hiding this comment

sonarcloud bot commented Oct 23, 2024

Quality Gate passed

ganfra left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 22, 2024 •

edited

Loading

codecov bot commented Oct 23, 2024 •

edited

Loading

bmarty Oct 23, 2024 •

edited

Loading

bmarty Oct 23, 2024 •

edited

Loading