Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BigIcon and fix colors #3719

Merged
merged 7 commits into from
Oct 22, 2024
Merged

Use BigIcon and fix colors #3719

merged 7 commits into from
Oct 22, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 22, 2024

Content

Iterate on BigIcon following Figma file: https://www.figma.com/design/G1xy0HDZKJf5TCRFmKb5d5/Compound-Android-Components?node-id=1960-553&node-type=frame&m=dev

Motivation and context

UI consistency.

Screenshots / GIFs

See recorded ones.

Tests

  • NA

Tested devices

  • NA

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty added the PR-Bugfix For bug fix label Oct 22, 2024
@bmarty bmarty requested a review from a team as a code owner October 22, 2024 10:50
@bmarty bmarty requested review from jmartinesp and removed request for a team October 22, 2024 10:50
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/GzkcMc

Copy link

sonarcloud bot commented Oct 22, 2024

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.02%. Comparing base (804506b) to head (2d9f83b).
Report is 22 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3719      +/-   ##
===========================================
- Coverage    83.02%   83.02%   -0.01%     
===========================================
  Files         1752     1752              
  Lines        43782    43768      -14     
  Branches      5122     5120       -2     
===========================================
- Hits         36351    36339      -12     
  Misses        5611     5611              
+ Partials      1820     1818       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 22, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 22, 2024
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bmarty bmarty merged commit 26da0f3 into develop Oct 22, 2024
34 checks passed
@bmarty bmarty deleted the feature/bma/iconSizeAndColor branch October 22, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants