Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: knock request to join #3725

Merged
merged 11 commits into from
Oct 23, 2024
Merged

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Oct 23, 2024

Content

This is the first iteration for the request to join feature.
Currently, missing parts are :

  • the knock message is not yet sent, because it needs a sdk updates
  • canceling knock request is not working because we can't get a room object for the membership KNOCKED, waiting for sdk too

Motivation and context

Partially handles #3690

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@ganfra ganfra added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Oct 23, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Oct 23, 2024
Copy link
Contributor

github-actions bot commented Oct 23, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/GTtXee

@ganfra ganfra added the PR-Wip For anything that isn't ready to ship and will be enabled at a later date label Oct 23, 2024
@ganfra ganfra force-pushed the feature/fga/knock_request_to_join branch from d382b7b to 7588b4e Compare October 23, 2024 13:44
@ganfra ganfra marked this pull request as ready for review October 23, 2024 13:44
@ganfra ganfra requested a review from a team as a code owner October 23, 2024 13:44
@ganfra ganfra requested review from jmartinesp and removed request for a team October 23, 2024 13:44
Copy link

sonarcloud bot commented Oct 23, 2024

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 89.50820% with 32 lines in your changes missing coverage. Please review.

Project coverage is 83.02%. Comparing base (26da0f3) to head (7588b4e).
Report is 28 commits behind head on develop.

Files with missing lines Patch % Lines
...ent/android/features/joinroom/impl/JoinRoomView.kt 92.04% 12 Missing and 2 partials ⚠️
...droid/features/joinroom/impl/di/CancelKnockRoom.kt 0.00% 5 Missing ⚠️
...ent/android/features/joinroom/impl/di/KnockRoom.kt 0.00% 3 Missing ⚠️
...eatures/roomlist/impl/components/RoomSummaryRow.kt 95.08% 2 Missing and 1 partial ⚠️
...list/impl/datasource/RoomListRoomSummaryFactory.kt 50.00% 1 Missing and 1 partial ⚠️
.../android/libraries/matrix/test/FakeMatrixClient.kt 60.00% 2 Missing ⚠️
...vite/impl/response/AcceptDeclineInvitePresenter.kt 50.00% 0 Missing and 1 partial ⚠️
...ndroid/features/joinroom/impl/JoinRoomPresenter.kt 95.00% 0 Missing and 1 partial ⚠️
...ndroid/features/joinroom/impl/di/JoinRoomModule.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3725      +/-   ##
===========================================
- Coverage    83.02%   83.02%   -0.01%     
===========================================
  Files         1752     1753       +1     
  Lines        43773    43925     +152     
  Branches      5120     5135      +15     
===========================================
+ Hits         36344    36469     +125     
- Misses        5611     5633      +22     
- Partials      1818     1823       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ganfra ganfra enabled auto-merge October 23, 2024 14:47
@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 23, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 23, 2024
@ganfra ganfra merged commit 98057c1 into develop Oct 23, 2024
30 checks passed
@ganfra ganfra deleted the feature/fga/knock_request_to_join branch October 23, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Wip For anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants