Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI iteration on the encryption settings #3750

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 29, 2024

Content

Iterate on crypto screen, UX flow and wording, so that it matches what has been designed at https://www.figma.com/design/qTWRfItpO3RdCjnTKPu4mL/Settings?node-id=1651-24968&node-type=canvas&m=dev

Motivation and context

Closes #3737
Closes #3738
Closes #3739

Screenshots / GIFs

CryptoIteration.mp4

Tests

  • Play with the "Encryption" settings and observe that the flow is similar to what's in Figma.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

Copy link
Contributor

github-actions bot commented Oct 29, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/UEdXGL

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 84.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 82.98%. Comparing base (e329370) to head (405543a).
Report is 30 commits behind head on develop.

Files with missing lines Patch % Lines
...res/securebackup/impl/root/SecureBackupRootView.kt 66.66% 19 Missing and 3 partials ⚠️
...es/securebackup/impl/root/SecureBackupRootState.kt 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3750      +/-   ##
===========================================
- Coverage    83.05%   82.98%   -0.07%     
===========================================
  Files         1754     1749       -5     
  Lines        43994    43973      -21     
  Branches      5142     5154      +12     
===========================================
- Hits         36539    36492      -47     
- Misses        5632     5656      +24     
- Partials      1823     1825       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty added the PR-Change For updates to an existing feature label Oct 29, 2024
Change wording of setup recovery key banner and change target to root.
Iterate on wording of encryption screen.
Change button to Switch.
Iterate on wording to delete key storage.
Iterate on wording and icon on the root setting.
Remove confirmation dialog when disabling backup.
Add subtitle to change recovery key action.
Enable key storage directly, remove quite empty screen to setup the backup.
Disable recovery action if key backup is disabled.
@bmarty bmarty force-pushed the feature/bma/cryptoIteration branch from 589af73 to 1e0c212 Compare October 29, 2024 13:55
@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Oct 29, 2024
@bmarty bmarty changed the title Feature/bma/crypto iteration UI iteration on the encryption settings Oct 29, 2024
@bmarty bmarty marked this pull request as ready for review October 29, 2024 13:59
@bmarty bmarty requested a review from a team as a code owner October 29, 2024 13:59
@bmarty bmarty requested review from jmartinesp and removed request for a team October 29, 2024 13:59
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Oct 29, 2024
@americanrefugee
Copy link

I mentioned 2 issues on #2590:

  1. After generating/saving the recovery key and clicking "Done", the user should see this confirmation page.
  2. After setting up the recovery key, the Settings menu item should simply say "Change recovery key" without any additional help text.

Copy link

sonarcloud bot commented Oct 29, 2024

@bmarty
Copy link
Member Author

bmarty commented Oct 29, 2024

Discussion was in #2590, so I think there is no blockers from @americanrefugee anymore.

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 30, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 30, 2024
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bmarty bmarty merged commit 1c020bc into develop Oct 30, 2024
29 of 30 checks passed
@bmarty bmarty deleted the feature/bma/cryptoIteration branch October 30, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Change For updates to an existing feature
Projects
None yet
4 participants