Change wording to "Verify identity" #3751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3751 +/- ##
========================================
Coverage 83.09% 83.10%
========================================
Files 1770 1771 +1
Lines 44378 44415 +37
Branches 5202 5207 +5
========================================
+ Hits 36878 36909 +31
- Misses 5669 5674 +5
- Partials 1831 1832 +1 ☔ View full report in Codecov by Sentry. |
pixlwave
reviewed
Oct 30, 2024
| @@ -106,7 +106,7 @@ fun UserProfileView( | |||
| private fun VerifyUserSection(state: UserProfileState) { | |||
| if (state.isVerified.dataOrNull() == false) { | |||
| ListItem( | |||
| headlineContent = { Text(stringResource(R.string.screen_room_member_details_verify_button_title, state.userName ?: state.userId)) }, | |||
| headlineContent = { Text(stringResource(CommonStrings.common_verify_identity)) }, | |||
There was a problem hiding this comment.
Should this be action.verify_identity as verify is a verb here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the discussion here: https://www.figma.com/design/0oUTCbYhROEDprSp7bdWhx?node-id=896-11141#1004391159