Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve FakeMatrixRoom to be able to check all the parameters. #3761

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 30, 2024

Preparatory work for testing the sending of media caption.

@bmarty bmarty added the PR-Misc For other changes label Oct 30, 2024
@bmarty bmarty requested a review from a team as a code owner October 30, 2024 18:12
@bmarty bmarty requested review from jmartinesp and removed request for a team October 30, 2024 18:12
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/g2dkjk

Copy link

sonarcloud bot commented Oct 30, 2024

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 46.29630% with 29 lines in your changes missing coverage. Please review.

Project coverage is 82.93%. Comparing base (0efe3bc) to head (4b98ee9).
Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
...droid/libraries/matrix/test/room/FakeMatrixRoom.kt 46.29% 29 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3761      +/-   ##
===========================================
- Coverage    82.97%   82.93%   -0.04%     
===========================================
  Files         1770     1770              
  Lines        44440    44483      +43     
  Branches      5224     5224              
===========================================
+ Hits         36873    36893      +20     
- Misses        5731     5754      +23     
  Partials      1836     1836              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bmarty bmarty merged commit 2e91357 into develop Oct 31, 2024
28 of 30 checks passed
@bmarty bmarty deleted the feature/bma/improveFakeMatrixRoom branch October 31, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants