Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency androidx.constraintlayout:constraintlayout-compose to v1.1.0 #3770

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Update dependency androidx.constraintlayout:constraintlayout-compose to v1.1.0 #3770

merged 2 commits into from
Nov 4, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 31, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
androidx.constraintlayout:constraintlayout-compose (source) 1.0.1 -> 1.1.0 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the PR-Dependencies Pull requests that update a dependency file label Oct 31, 2024
@renovate renovate bot requested a review from a team as a code owner October 31, 2024 00:35
@renovate renovate bot requested review from jmartinesp and removed request for a team October 31, 2024 00:35
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 31, 2024 •
edited
Loading

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/6LBn5p

@jmartinesp jmartinesp added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Oct 31, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Oct 31, 2024
@jmartinesp
Copy link
Member

This update breaks the timeline view, it'll probably need some work before it can be merged or we'll need to skip this version.

@codecov Codecov
Copy link

codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.91%. Comparing base (17ea2aa) to head (7861342).
Report is 2 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #3770   +/-   ##
========================================
  Coverage    82.90%   82.91%           
========================================
  Files         1772     1772           
  Lines        44531    44534    +3     
  Branches      5225     5226    +1     
========================================
+ Hits         36920    36924    +4     
  Misses        5780     5780           
+ Partials      1831     1830    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate Renovate
Copy link
Contributor Author

renovate bot commented Oct 31, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

bmarty
bmarty reviewed Oct 31, 2024
View reviewed changes
...ts/images/features.messages.impl.timeline.components_TimelineItemEventRowWithRR_Day_0_en.png Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case the screenshot looks better

bmarty
bmarty requested changes Oct 31, 2024
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked

@bmarty
Copy link
Member

bmarty commented Oct 31, 2024

Maybe it needs #3769 ?

@bmarty bmarty force-pushed the renovate/constraintlayout.compose branch from 2b28d4a to a75b53c Compare October 31, 2024 09:01
@bmarty bmarty mentioned this pull request Oct 31, 2024
Closed
1 task
@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Oct 31, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Oct 31, 2024
@jmartinesp
Copy link
Member

Maybe it needs #3769 ?

It seems like it still has the same issue.

@ganfra
Copy link
Member

ganfra commented Oct 31, 2024

yup UI is broken...

@jmartinesp jmartinesp force-pushed the renovate/constraintlayout.compose branch from 5a888e4 to 1ef746c Compare November 4, 2024 14:18
@jmartinesp jmartinesp force-pushed the renovate/constraintlayout.compose branch from 1ef746c to 7861342 Compare November 4, 2024 15:09
jmartinesp
jmartinesp approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like using the right logic fixed the bug!

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 4, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 4, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

bmarty
bmarty approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jmartinesp jmartinesp merged commit 8abb1dd into develop Nov 4, 2024
28 of 30 checks passed
@jmartinesp jmartinesp deleted the renovate/constraintlayout.compose branch November 4, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

@jmartinesp jmartinesp jmartinesp approved these changes

Assignees
No one assigned
Labels
PR-Dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmartinesp @bmarty @ganfra