-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable predictive back gesture #3797
Conversation
This only animates closing the app, but it's better than nothing. Signed-off-by: Joe Groocock <me@frebib.net>
Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3797 +/- ##
==========================================
Coverage ? 82.92%
==========================================
Files ? 1771
Lines ? 44481
Branches ? 5222
==========================================
Hits ? 36887
Misses ? 5755
Partials ? 1839 ☔ View full report in Codecov by Sentry. |
I can't find any issues with it either, although the mentioned bug wasn't fixed by Google or at least it wasn't marked as fixed 🤔 . @bmarty , @ganfra can I ping you for more thorough testing / opinions on this? |
If back press when a bottom sheet is displayed behave correctly, I guess we can take the risk to merge this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this as I couldn't find any issues. Thanks!
Content
Enable Android 15+ Predictive back gesture that was previously disabled
It only animates closing the app for now, but it's better than nothing.
Fixes #3795
Motivation and context
Google/Android want everything to support this eventually. It doesn't do anything special with Appyx animations yet, but at least it integrates with the OS and app-closing animations.
The mentioned bug, whilst still open, doesn't appear to happen any more, at least from my testing.
I have been running this patch for a couple of months and haven't really noticed any issues relating to it.
I will note that recently ~last month or so (?) I've been having issues with the keyboard not closing automatically when it should and I'm unsure whether it's caused by this patch, or some other upstream change/patch I'm carrying. Mentioning here mostly in case this gets merged and others report similar issues that coincide with the merge of this
Screenshots / GIFs
209d530b-cf50-41a3-9d01-5e34577784e2.mp4
Tests
Tested devices
Checklist