Knocking : update create room flow #3804

ganfra · 2024-11-04T15:28:34Z

Content

This PR updates the create room flow with the following changes :

Allow setting public room join rule to either "anyone" or "ask to join"
Allow setting a room alias (no validation nor auto-fill for now)

There is a new feature flag to enable to see the updated flow.

Motivation and context

Handles some parts of #3689

Screenshots / GIFs

Tests

Enable Knock feature flag
Go to the room list and click on the start chat button
Click on "new room"
Select people or not
Play with settings

Tested devices

Physical
Emulator
OS version(s):

Checklist

Changes have been tested on an Android device or Android emulator with API 23
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request title will be used in the release note, it clearly define what will change for the user
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off
You've made a self review of your PR

github-actions · 2024-11-04T15:34:40Z

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/hWfEnu

jmartinesp

LGTM, just a few suggestions.

jmartinesp · 2024-11-06T08:20:32Z

...room/impl/src/main/kotlin/io/element/android/features/createroom/impl/CreateRoomDataStore.kt

@@ -31,28 +37,87 @@ class CreateRoomDataStore @Inject constructor(
            field = value
        }

-    fun getCreateRoomConfig(): Flow<CreateRoomConfig> = combine(
+    val createRoomConfig: Flow<CreateRoomConfig> = combine(


Maybe rename to createRoomConfigWithInvites?

...room/impl/src/main/kotlin/io/element/android/features/createroom/impl/CreateRoomDataStore.kt

jmartinesp · 2024-11-06T08:46:53Z

...c/main/kotlin/io/element/android/features/createroom/impl/components/RoomVisibilityOption.kt

+        Box(
+            modifier = modifier
+                .size(30.dp)
+                .clip(RoundedCornerShape(8.dp))
+                .background(ElementTheme.colors.bgSubtleSecondary)
+                .padding(3.dp),
+            contentAlignment = Alignment.Center,


I think we have RoundedIconAtom for this.

jmartinesp · 2024-11-06T08:50:04Z

...c/main/kotlin/io/element/android/features/createroom/impl/configureroom/ConfigureRoomView.kt

 @PreviewsDayNight
+@PreviewWithLargeHeight


I'm not sure if we can combine preview annotations like this 🫤 . In fact, I don't see a 'long' screenshot being recorded. We'd have to manually add @Preview(height = ...) and @Preview(uiMode = Configuration.UI_MODE_NIGHT_YES, height = ...) to it instead if I'm not mistaken.

Yes, I've removed it in the last commits. I'll fix it in another PR with the final design

jmartinesp · 2024-11-06T08:50:35Z

...mpl/src/main/kotlin/io/element/android/features/createroom/impl/configureroom/RoomAddress.kt

+sealed interface RoomAddress {
+    data class AutoFilled(val address: String) : RoomAddress
+    data class Edited(val address: String) : RoomAddress
+}


jmartinesp · 2024-11-06T08:58:15Z

...l/src/main/kotlin/io/element/android/features/createroom/impl/components/RoomAccessOption.kt

+            modifier
+                    .fillMaxWidth()
+                    .selectable(
+                            selected = isSelected,
+                            onClick = { onOptionClick(roomAccessItem) },
+                            role = Role.RadioButton,
+                    )


One day we have to debug why your formatter does this 😓 .

I agree it's polluting our PRs.

jmartinesp · 2024-11-06T09:13:17Z

...c/main/kotlin/io/element/android/features/createroom/impl/components/RoomVisibilityOption.kt

-fun RoomPrivacyOption(
-    roomPrivacyItem: RoomPrivacyItem,
-    onOptionClick: (RoomPrivacyItem) -> Unit,
+fun RoomVisibilityOption(


Now that I think about it, maybe this should use a ListItem inside instead?

jmartinesp · 2024-11-06T09:18:34Z

...l/src/main/kotlin/io/element/android/features/createroom/impl/components/RoomAccessOption.kt

+@Composable
+fun RoomAccessOption(
+    roomAccessItem: RoomAccessItem,
+    onOptionClick: (RoomAccessItem) -> Unit,
+    modifier: Modifier = Modifier,
+    isSelected: Boolean = false,
+) {
+    Row(


This should probably use a ListItem too.

sonarcloud · 2024-11-06T14:16:23Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov · 2024-11-06T14:33:39Z

Codecov Report

Attention: Patch coverage is 77.91165% with 55 lines in your changes missing coverage. Please review.

Project coverage is 82.86%. Comparing base (98bf685) to head (2ab6289).
Report is 23 commits behind head on develop.

Files with missing lines	Patch %	Lines
...id/features/createroom/impl/CreateRoomDataStore.kt	45.45%	16 Missing and 2 partials ⚠️
...eroom/impl/configureroom/ConfigureRoomPresenter.kt	63.15%	11 Missing and 3 partials ⚠️
...createroom/impl/configureroom/ConfigureRoomView.kt	88.37%	7 Missing and 3 partials ⚠️
...eateroom/impl/configureroom/RoomVisibilityState.kt	63.63%	3 Missing and 1 partial ⚠️
...atures/createroom/impl/configureroom/RoomAccess.kt	40.00%	3 Missing ⚠️
...eateroom/impl/configureroom/ConfigureRoomEvents.kt	60.00%	2 Missing ⚠️
...teroom/impl/configureroom/RoomAddressErrorState.kt	33.33%	2 Missing ⚠️
...tures/createroom/impl/configureroom/RoomAddress.kt	66.66%	1 Missing ⚠️
...ibraries/matrix/api/createroom/JoinRuleOverride.kt	50.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3804      +/-   ##
===========================================
- Coverage    82.91%   82.86%   -0.05%     
===========================================
  Files         1772     1776       +4     
  Lines        44534    44673     +139     
  Branches      5227     5242      +15     
===========================================
+ Hits         36924    37019      +95     
- Misses        5780     5821      +41     
- Partials      1830     1833       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ganfra added 8 commits November 4, 2024 15:39

create room : start adding new options in ui

8c989f7

create room : remove RoomAccess.Invite as we are not displaying it.

dc9e883

create room : use user homeserver in the address field.

9e2b01e

create room : branch the join rule override

f0c1dfa

create room : start integrating the address field

a4be210

create room : add Knock feature flag

68bdc31

create room : fix tests and remove auto-fill alias for now.

1b1884c

create room : remove hardcoded strings and sync strings.

59168e4

Merge branch 'develop' into feature/fga/update_create_room_flow

9aa08ac

ganfra added PR-Wip For anything that isn't ready to ship and will be enabled at a later date Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. labels Nov 5, 2024

github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 5, 2024

ElementBot and others added 4 commits November 5, 2024 08:44

Update screenshots

0ebb210

create room : fix konsist test

ed1d208

create room : override invite power level for knockable rooms

4ff1e79

Merge branch 'develop' into feature/fga/update_create_room_flow

e777539

ganfra marked this pull request as ready for review November 5, 2024 20:17

ganfra requested a review from a team as a code owner November 5, 2024 20:17

ganfra requested review from jmartinesp and removed request for a team November 5, 2024 20:17

jmartinesp approved these changes Nov 6, 2024

View reviewed changes

jmartinesp added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 6, 2024

github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 6, 2024

jmartinesp reviewed Nov 6, 2024

View reviewed changes

ElementBot and others added 2 commits November 6, 2024 09:18

Update screenshots

6f1de0c

create room : clean up after review.

24d4270

ganfra added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 6, 2024

ganfra enabled auto-merge November 6, 2024 13:58

github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 6, 2024

Update screenshots

2ab6289

ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 6, 2024

github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 6, 2024

ganfra merged commit a678fe4 into develop Nov 6, 2024
28 of 30 checks passed

ganfra deleted the feature/fga/update_create_room_flow branch November 6, 2024 14:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Knocking : update create room flow #3804

Knocking : update create room flow #3804

ganfra commented Nov 4, 2024 •

edited

Loading

github-actions bot commented Nov 4, 2024 •

edited

Loading

jmartinesp left a comment

jmartinesp Nov 6, 2024

jmartinesp Nov 6, 2024

jmartinesp Nov 6, 2024

ganfra Nov 6, 2024

jmartinesp Nov 6, 2024

jmartinesp Nov 6, 2024

bmarty Nov 6, 2024

jmartinesp Nov 6, 2024

jmartinesp Nov 6, 2024

sonarcloud bot commented Nov 6, 2024

codecov bot commented Nov 6, 2024 •

edited

Loading

		@PreviewsDayNight
		@PreviewWithLargeHeight

Knocking : update create room flow #3804

Knocking : update create room flow #3804

Conversation

ganfra commented Nov 4, 2024 • edited Loading

Content

Motivation and context

Screenshots / GIFs

Tests

Tested devices

Checklist

github-actions bot commented Nov 4, 2024 • edited Loading

jmartinesp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarcloud bot commented Nov 6, 2024

Quality Gate passed

codecov bot commented Nov 6, 2024 • edited Loading

Codecov Report

ganfra commented Nov 4, 2024 •

edited

Loading

github-actions bot commented Nov 4, 2024 •

edited

Loading

codecov bot commented Nov 6, 2024 •

edited

Loading