Use in-memory thumbnail APIs when possible

[jmartinesp]

Content

• Instead of using Client.getMediaFIle(...) to load thumbnails, use Client.getMediaThumbnail(...). This fixes a bug with upcoming new Rust APIs where thumbnails for videos weren't being displayed.
• Add thumbnail dimensions info to TimelineItemImageContent and TimelineItemVideoContent.
• For images in timeline items, try loading the thumbnail source if it exists, use the actual media source otherwise.
• Add default values for thumbnail sizes if none is provided.
• Removes redundant ByteArray.toUByteArray().toByteArray() transformation. This was needed before because uniffi returned something like Array<UByte> instead, but it now returns a proper ByteArray.

Motivation and context

Fix issue in upcoming SDK versions, use the right APIs when possible.

Tests

• Clear the cache.
• Open a room with media items.

Tested devices

• Physical
• Emulator
• OS version(s): 14

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/ziXR77

[codecov]

Codecov Report

Attention: Patch coverage is 48.27586% with 15 lines in your changes missing coverage. Please review.

Project coverage is 82.88%. Comparing base (98bf685) to head (daba49c).
Report is 56 commits behind head on develop.

Files with missing lines	Patch %	Lines
...l/timeline/model/event/TimelineItemImageContent.kt	35.71%	5 Missing and 4 partials ⚠️
...ctories/event/TimelineItemContentMessageFactory.kt	0.00%	0 Missing and 4 partials ⚠️
...timeline/components/event/TimelineItemVideoView.kt	33.33%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3817      +/-   ##
===========================================
- Coverage    82.91%   82.88%   -0.03%     
===========================================
  Files         1772     1772              
  Lines        44534    44551      +17     
  Branches      5227     5235       +8     
===========================================
+ Hits         36924    36928       +4     
- Misses        5780     5784       +4     
- Partials      1830     1839       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ganfra]

I think we should keep content.preferredMediaSource and always use kind = MediaRequestData.Kind.Thumbnail

[ganfra]

Except, the thumbnailAPI is probably not working with GIF?

[jmartinesp]

Nope, it doesn't work properly... I guess we'll need to check the mime type here too.

[ganfra]

This is already done in preferredMediaSource, so maybe we could have a mediaRequestData extension function in Content, to pick the correct source and kind?

[jmartinesp]

I tried something like that in 6da362e.

[ganfra]

But why do you want to use Kind.File when using mediaSource (except for isMimeTypeAnimatedImage I mean).
I'd have done something like that :

val thumbnailMediaRequest: MediaRequestData by lazy {
        if (mimeType.isMimeTypeAnimatedImage()) {
            MediaRequestData(
                source = mediaSource,
                kind = MediaRequestData.Kind.File(
                    fileName = filename,
                    mimeType = mimeType
                )
            )
        } else {
            MediaRequestData(
                source = thumbnailSource ?: mediaSource,
                kind = MediaRequestData.Kind.Thumbnail(
                    width = thumbnailWidth?.toLong() ?: MAX_THUMBNAIL_WIDTH,
                    height = thumbnailHeight?.toLong() ?: MAX_THUMBNAIL_HEIGHT
                ),
            )
        }
    }

and removed the preferredMediaSource?

[jmartinesp]

Used this in daba49c.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[jmartinesp]

Just a heads up: this is needed to fix a bug with the media upload + send queue implementation, so it should be merged soon-ish.

[ganfra]

Thanks for the changes, LGTM!