Disable button during the "verifying" step. #3832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3832 +/- ##
========================================
Coverage 83.00% 83.00%
========================================
Files 1782 1782
Lines 44889 44899 +10
Branches 5278 5279 +1
========================================
+ Hits 37261 37270 +9
Misses 5791 5791
- Partials 1837 1838 +1 ☔ View full report in Codecov by Sentry. |
bmarty
force-pushed
the
feature/bma/waitingtoMatch
branch
from
82f150b
to
8b21efa
Compare
bmarty
added
Record-Screenshots
github-actions
bot
removed
the
Record-Screenshots
ganfra
reviewed
Nov 7, 2024
| @@ -118,6 +119,14 @@ fun TextButton( | |||
| leadingIcon = leadingIcon | |||
| ) | |||
|
|
|||
| @Composable | |||
| fun InvisibleButton( | |||
There was a problem hiding this comment.
I think it's a bit weird to have an InvisibleButton api?
There was a problem hiding this comment.
I can't think of a better idea, let's keep this for now.
|
ganfra
approved these changes
Nov 8, 2024
bmarty
added
the
Run-Maestro
github-actions
bot
removed
the
Run-Maestro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A point missing in #3829
Figma: https://www.figma.com/design/pDlJZGBsri47FNTXMnEdXB/Compound-Android-Templates?node-id=41-10333
(see the recorded screenshot)