-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the strings for unsupported calls #3857
Conversation
is CallNotifyContent -> { | ||
sp.getString(CommonStrings.common_call_started) | ||
} | ||
RedactedContent, | ||
is LegacyCallInviteContent, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The case is CallNotifyContent
should probably be moved here as well, but this is a bit out of scope of this PR.
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Just to confirm, is the text used for the timeline item the right one? The issue mentions using:
But the included text seems to be different. Also, just having "Unsupported call" as the notification messages seems weird to me, there's plenty of space to explain why it's not supported. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3857 +/- ##
===========================================
- Coverage 82.97% 82.97% -0.01%
===========================================
Files 1783 1783
Lines 44985 44982 -3
Branches 5296 5296
===========================================
- Hits 37328 37325 -3
+ Misses 5806 5805 -1
- Partials 1851 1852 +1 ☔ View full report in Codecov by Sentry. |
This wording is in the section About the notification content, I have done what's been done on iOS in https://github.com/element-hq/element-x-ios/pull/3502/files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM then, thanks.
Content
Iterate on the strings used to renders legacy call in:
Motivation and context
Closes #3853
Screenshots / GIFs
Element.X.unsupported.call.mp4
Tests
Tested devices
Checklist