Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the strings for unsupported calls #3857

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Nov 12, 2024

Content

Iterate on the strings used to renders legacy call in:

  • notification
  • room list last message
  • timeline

Motivation and context

Closes #3853

Screenshots / GIFs

Element.X.unsupported.call.mp4

Tests

  • Alice uses Element X
  • Bob is using Element Web
  • Bob starts a voice call using Element Web
  • Alice should see all the unsupported strings regarding the incoming call as per the video above.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner November 12, 2024 09:42
@bmarty bmarty requested review from jmartinesp and removed request for a team November 12, 2024 09:42
is CallNotifyContent -> {
sp.getString(CommonStrings.common_call_started)
}
RedactedContent,
is LegacyCallInviteContent,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The case is CallNotifyContent should probably be moved here as well, but this is a bit out of scope of this PR.

@bmarty bmarty added the PR-Change For updates to an existing feature label Nov 12, 2024
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/wr8fVx

@jmartinesp
Copy link
Member

jmartinesp commented Nov 12, 2024

Just to confirm, is the text used for the timeline item the right one? The issue mentions using:

Unsupported call. The new Element X app is needed to join this call.

But the included text seems to be different. Also, just having "Unsupported call" as the notification messages seems weird to me, there's plenty of space to explain why it's not supported.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.97%. Comparing base (7574fef) to head (70dbcde).
Report is 17 commits behind head on develop.

Files with missing lines Patch % Lines
...s/messagesummary/DefaultMessageSummaryFormatter.kt 0.00% 1 Missing ⚠️
...tformatter/impl/DefaultRoomLastMessageFormatter.kt 0.00% 1 Missing ⚠️
...entformatter/impl/DefaultTimelineEventFormatter.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3857      +/-   ##
===========================================
- Coverage    82.97%   82.97%   -0.01%     
===========================================
  Files         1783     1783              
  Lines        44985    44982       -3     
  Branches      5296     5296              
===========================================
- Hits         37328    37325       -3     
+ Misses        5806     5805       -1     
- Partials      1851     1852       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty
Copy link
Member Author

bmarty commented Nov 12, 2024

Just to confirm, is the text used for the timeline item the right one? The issue mentions using:

Unsupported call. The new Element X app is needed to join this call.

But the included text seems to be different. Also, just having "Unsupported call" as the notification messages seems weird to me, there's plenty of space to explain why it's not supported.

This wording is in the section Legacy side. This PR is for Element X, so it would be strange to ask the user to use Element X in the Element X app (I do not blame you, I am also confused sometimes with all this legacy / x things)

About the notification content, I have done what's been done on iOS in https://github.com/element-hq/element-x-ios/pull/3502/files

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM then, thanks.

@bmarty bmarty merged commit 9863cbf into develop Nov 12, 2024
25 of 29 checks passed
@bmarty bmarty deleted the feature/bma/legacyCallIteration branch November 12, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Change For updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Update the notification/timeline strings for legacy calls.
3 participants