-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use formatted captions for images and video #3864
Conversation
…`Charsequence?`, parse the formatted caption body as we do for text message bodies
… the click action should be triggered at the message bubble level or when some internal content is tapped instead.
…content of the timeline item depending on `TimelineItem.isWholeContentClickable`.
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
This is complemented by matrix-org/matrix-rust-sdk#4261, which allows generating HTML formatted body from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
glad to see the fix has landed, thank you! <3 |
Content
This PR has the following changes:
caption
andformattedCaption
in the same way as we do for text messages.onClick
action for timeline items between those whose onClick action should be triggered by the whole message bubble and those who should trigger it only from certain UI elements (as the image/video preview in the timeline).Note there's no way to send captions as either markdown or HTML at the moment from the app, so either you send these from some other client or you'd only be able to test this by sending a URL as part of the plain text caption.
This PR can be reviewed commit-by-commit.
Motivation and context
Fixes #3850.
Screenshots / GIFs
No changes in screenshots, I hope.
Tests
Tested devices
Checklist