Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create room : improve handling of room address #3868

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Nov 13, 2024

Content

This PR improves the room address field management :

  • Add some validation (check format validity and availability)
  • Branch the autofill using the name

Motivation and context

Closes #3866
Closes #3867

Screenshots / GIFs

Check recorded screenshots for new states.

Tests

  • Open create room flow
  • Add a name
  • Set visibility to public
  • Play with the address and name fields

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@ganfra ganfra marked this pull request as ready for review November 13, 2024 16:37
@ganfra ganfra requested a review from a team as a code owner November 13, 2024 16:37
@ganfra ganfra requested review from jmartinesp and removed request for a team November 13, 2024 16:37
Copy link
Contributor

github-actions bot commented Nov 13, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/6hkKxE

@ganfra ganfra force-pushed the feature/fga/create_room_improve_address branch from 277b859 to 5c1a103 Compare November 13, 2024 16:56
@ganfra ganfra added PR-Wip For anything that isn't ready to ship and will be enabled at a later date Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. labels Nov 13, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 89.36170% with 10 lines in your changes missing coverage. Please review.

Project coverage is 82.87%. Comparing base (5c354ba) to head (0a223c3).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...eroom/impl/configureroom/ConfigureRoomPresenter.kt 78.12% 3 Missing and 4 partials ⚠️
...id/features/createroom/impl/CreateRoomDataStore.kt 75.00% 2 Missing ⚠️
...reateroom/impl/configureroom/ConfigureRoomState.kt 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3868      +/-   ##
===========================================
+ Coverage    82.84%   82.87%   +0.02%     
===========================================
  Files         1783     1784       +1     
  Lines        45014    45090      +76     
  Branches      5312     5324      +12     
===========================================
+ Hits         37293    37368      +75     
+ Misses        5861     5857       -4     
- Partials      1860     1865       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 14, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 14, 2024
Copy link

sonarcloud bot commented Nov 14, 2024

@ganfra ganfra merged commit b772d4f into develop Nov 14, 2024
29 checks passed
@ganfra ganfra deleted the feature/fga/create_room_improve_address branch November 14, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Wip For anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
3 participants