Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove :samples:minimal module #3871

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Remove :samples:minimal module #3871

merged 1 commit into from
Nov 14, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Nov 14, 2024

Content

Remove :samples:minimal module

Motivation and context

Developers are not using it and we still have to maintain it. And recently the CI is having some trouble with it, so better to just remove it.

Screenshots / GIFs

NA

Tests

NA

Tested devices

NA

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner November 14, 2024 08:07
@bmarty bmarty requested review from jmartinesp and removed request for a team November 14, 2024 08:08
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/QsakF3

Copy link

sonarcloud bot commented Nov 14, 2024

@bmarty bmarty added the PR-Misc For other changes label Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.84%. Comparing base (a132be2) to head (4c61e5d).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3871   +/-   ##
========================================
  Coverage    82.84%   82.84%           
========================================
  Files         1783     1783           
  Lines        45014    45014           
  Branches      5312     5312           
========================================
+ Hits         37293    37294    +1     
  Misses        5861     5861           
+ Partials      1860     1859    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmarty bmarty merged commit 5c354ba into develop Nov 14, 2024
29 checks passed
@bmarty bmarty deleted the feature/bma/removeSample branch November 14, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants