Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace textPlaceholder color usages with textSecondary #3873

Merged

Conversation

jmartinesp
Copy link
Member

Content

Replaces usages of textPlaceholder with textSecondary.

Motivation and context

Improve accessiblity. cc @americanrefugee .

Screenshots / GIFs

In the PR. The placeholder texts should have more contrast now.

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@jmartinesp jmartinesp added the PR-Misc For other changes label Nov 14, 2024
@jmartinesp jmartinesp requested a review from a team as a code owner November 14, 2024 17:16
@jmartinesp jmartinesp requested review from ganfra and removed request for a team November 14, 2024 17:16
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/55V5bA

Copy link

sonarcloud bot commented Nov 14, 2024

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.87%. Comparing base (b772d4f) to head (c250ca2).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3873   +/-   ##
========================================
  Coverage    82.87%   82.87%           
========================================
  Files         1784     1784           
  Lines        45090    45090           
  Branches      5324     5324           
========================================
  Hits         37368    37368           
  Misses        5857     5857           
  Partials      1865     1865           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 15, 2024
@jmartinesp jmartinesp enabled auto-merge (squash) November 15, 2024 07:23
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 15, 2024
@jmartinesp jmartinesp merged commit 1b6f77d into develop Nov 15, 2024
33 checks passed
@jmartinesp jmartinesp deleted the misc/compound-remove-text-placeholder-color-usages branch November 15, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants