-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide the keyboard when navigating from the chat room screen #3878
Hide the keyboard when navigating from the chat room screen #3878
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
fun hidingKeyboard(block: () -> Unit) { | ||
localView.hideKeyboard() | ||
block() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice pattern!
}, | ||
onRoomDetailsClick = onRoomDetailsClick, | ||
onBackClick = { hidingKeyboard { onBackClick() } }, | ||
onRoomDetailsClick = { hidingKeyboard { onRoomDetailsClick() } }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about also wrapping onJoinCallClick
below but since it will start another Activity, I think it's fine to keep the keyboard opened.
068a2db
to
b75cf92
Compare
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3878 +/- ##
========================================
Coverage 82.87% 82.87%
========================================
Files 1785 1785
Lines 45100 45100
Branches 5324 5324
========================================
Hits 37377 37377
Misses 5857 5857
Partials 1866 1866 ☔ View full report in Codecov by Sentry. |
Content
Hide the keyboard when the composer is in use when:
Motivation and context
It seems like this became a regression.
Tests
Tested devices
Checklist